linux-edac.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>,
	"Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>,
	Aristeu Rozanski <aris@redhat.com>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
Subject: RE: [PATCH 1/2] EDAC, skx_common: Refactor so that we initialize "dev" in result of adxl decode.
Date: Mon, 23 Sep 2019 23:36:57 +0000	[thread overview]
Message-ID: <3908561D78D1C84285E8C5FCA982C28F7F478D2A@ORSMSX115.amr.corp.intel.com> (raw)
In-Reply-To: <20190918074040.3e76a2ac@coco.lan>

>> +	if (res->imc > NUM_IMC - 1) {
>> +		skx_printk(KERN_ERR, "Bad imc %d\n", res->imc);
>
> I would report this via EDAC as well.

It would be nice, but I don't see how.  This function is trying to figure
out which memory controller (and thus which EDAC struct mem_ctl_info)
is connected to this error.  If it fails, then we don't know where to report it.

On the plus side this error (and the other one you flagged) "can't happen"(TM)
so we shouldn't expend too much effort to solve this.  Code must give up here
rather than trigger out of bounds array accesses later.

If we did want to solve this, we could invent a mechanism for EDAC
drivers to log errors not related to a particular memory controller
(by passing NULL to edac_mc_handle_error()???).

-Tony

  reply	other threads:[~2019-09-23 23:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-13 22:13 [PATCH 0/2] EDAC, skx: Provide more machine specific location detail Tony Luck
2019-09-13 22:13 ` [PATCH 1/2] EDAC, skx_common: Refactor so that we initialize "dev" in result of adxl decode Tony Luck
2019-09-18 10:40   ` Mauro Carvalho Chehab
2019-09-23 23:36     ` Luck, Tony [this message]
2019-09-13 22:13 ` [RFC PATCH 2/2] EDAC, skx: Retrieve and print retry_rd_err_log registers Tony Luck
2019-09-18 10:52   ` Mauro Carvalho Chehab
2019-09-23 23:57     ` Luck, Tony
2019-09-24 21:52     ` [PATCHv2 " Tony Luck
2019-09-17 20:05 ` [PATCH 0/2] EDAC, skx: Provide more machine specific location detail Aristeu Rozanski
2019-09-18 10:30   ` Mauro Carvalho Chehab
2019-09-25 13:51 ` Aristeu Rozanski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3908561D78D1C84285E8C5FCA982C28F7F478D2A@ORSMSX115.amr.corp.intel.com \
    --to=tony.luck@intel.com \
    --cc=aris@redhat.com \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=qiuxu.zhuo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).