linux-edac.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: 'Aristeu Rozanski' <aris@redhat.com>,
	"'linux-edac@vger.kernel.org'" <linux-edac@vger.kernel.org>
Cc: 'Borislav Petkov' <bp@alien8.de>,
	'Mauro Carvalho Chehab' <mchehab@kernel.org>
Subject: RE: [PATCH] EDAC: skx_common: downgrade message importance on missing PCI device
Date: Tue, 10 Dec 2019 00:02:45 +0000	[thread overview]
Message-ID: <3908561D78D1C84285E8C5FCA982C28F7F4F19BD@ORSMSX115.amr.corp.intel.com> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F7F4F13AB@ORSMSX115.amr.corp.intel.com>

> This looks like we call skx_init() once per core. Do we keep calling it because
> the calls are failing?  Or do we do that even when calls succeed?
>
> I was only really expecting that skx_init() would be called once.

So (by experimentation) it seems that if the module load fails it
will be retried num_online_cpus times (though not bound to each
CPU in turn ... it will maybe try the init call on the same CPU multiple
times, but miss running on some CPUs).

If the load succeeds, then whoever is repeating the load decides
to stop.

-Tony

  reply	other threads:[~2019-12-10  0:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04 21:23 [PATCH] EDAC: skx_common: downgrade message importance on missing PCI device Aristeu Rozanski
2019-12-09 21:52 ` Luck, Tony
2019-12-10  0:02   ` Luck, Tony [this message]
2019-12-10  9:00     ` Borislav Petkov
2020-01-06 15:12       ` 'Aristeu Rozanski'
2020-01-06 16:17         ` Borislav Petkov
2020-01-06 16:20           ` 'Aristeu Rozanski'
2020-01-06 16:23             ` Borislav Petkov
2020-01-07 15:51               ` 'Aristeu Rozanski'
2020-01-07 16:45                 ` Borislav Petkov
2020-01-07 21:43                   ` Luck, Tony
2020-01-08 14:54                     ` 'Aristeu Rozanski'
2019-12-10 14:18     ` 'Aristeu Rozanski'

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3908561D78D1C84285E8C5FCA982C28F7F4F19BD@ORSMSX115.amr.corp.intel.com \
    --to=tony.luck@intel.com \
    --cc=aris@redhat.com \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).