From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65A53C4CEC7 for ; Fri, 13 Sep 2019 14:51:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C4D22089F for ; Fri, 13 Sep 2019 14:51:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568386264; bh=3O2EFyMvl4FydsIhvt/igmGTAWUXY533WsMeM5QFj0w=; h=From:Cc:Subject:Date:In-Reply-To:References:To:List-ID:From; b=dUcoP4hEIWyPbv29Neu0PfDHkvnJJPZmVu1DSz+fUin6kQq9ldRfYrOh8FMnf0RGg Jf2/22Hw7t97cweDrYeD6JgrdjieZNY+RluLJgd1A+Vnpm3iqeuODGgf0oBed1D2AY uagUb7JdFdd9SvnqM1rEibaaLHmmRMqmOTU3ixVo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389180AbfIMOui (ORCPT ); Fri, 13 Sep 2019 10:50:38 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:40792 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388997AbfIMOuh (ORCPT ); Fri, 13 Sep 2019 10:50:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=WHvF2CG3hSL6Apn9kwopSnBjSdtlbe1zgSHAEIpSxc8=; b=q6l1RWGrXGSXR5d/aXatJKo44b goPcIt2gp4yQEBUgERRBuc6sNqqBSSFqK+aUbJpTTAGxleKKkj1n+OhDCTP7MVIgvdaBr1cbfBReo hqqj4nxCaMeEkopchd0J3W17ukwLpNnVaq38VxEWryNhh/JWDQxDfE9/udqlUe3NRbGhx8iMwoc1d ky9GVS6orXqkZMiTaVQp8y340QswvVepLcrJmhg2YUSGNXtTRVbehrY42n4fw6k2a22ng/fi/m0xZ ed20VIe41AFaGWfsVryggFPlK3ZuIqHzQYTp8KlE5EjQuGwtyEuM65lkDhU1CILuyMM0d5xpnaapK 7N311Bhg==; Received: from 177.96.232.144.dynamic.adsl.gvt.net.br ([177.96.232.144] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8muC-0002Mt-5b; Fri, 13 Sep 2019 14:50:36 +0000 Received: from mchehab by bombadil.infradead.org with local (Exim 4.92.2) (envelope-from ) id 1i8mu9-000432-Gl; Fri, 13 Sep 2019 11:50:33 -0300 From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , Linux Edac Mailing List , Linux Kernel Mailing List , Borislav Petkov , Tony Luck , James Morse , Robert Richter Subject: [PATCH 4/7] EDAC: i5400_edac: print type at debug message Date: Fri, 13 Sep 2019 11:50:29 -0300 Message-Id: <426c979d7ed44f23eeeda69bcdbc91609d2d3bb7.1568385816.git.mchehab+samsung@kernel.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org There are 3 types of non-recoverable errors that the MC reports: - Fatal; - Non-fatal uncorrected - Non-fatal correctable While we don't add it to the log itself, it could be useful to have this at least for debug messages. This shuts up this warning: drivers/edac/i5400_edac.c: In function ‘i5400_proccess_non_recoverable_info’: drivers/edac/i5400_edac.c:524:8: warning: variable ‘type’ set but not used [-Wunused-but-set-variable] 524 | char *type = NULL; | ^~~~ Signed-off-by: Mauro Carvalho Chehab --- drivers/edac/i5400_edac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/edac/i5400_edac.c b/drivers/edac/i5400_edac.c index 6f8bcdb9256a..52783b9bd0df 100644 --- a/drivers/edac/i5400_edac.c +++ b/drivers/edac/i5400_edac.c @@ -548,8 +548,8 @@ static void i5400_proccess_non_recoverable_info(struct mem_ctl_info *mci, ras = nrec_ras(info); cas = nrec_cas(info); - edac_dbg(0, "\t\tDIMM= %d Channels= %d,%d (Branch= %d DRAM Bank= %d Buffer ID = %d rdwr= %s ras= %d cas= %d)\n", - rank, channel, channel + 1, branch >> 1, bank, + edac_dbg(0, "\t\t%s DIMM= %d Channels= %d,%d (Branch= %d DRAM Bank= %d Buffer ID = %d rdwr= %s ras= %d cas= %d)\n", + type, rank, channel, channel + 1, branch >> 1, bank, buf_id, rdwr_str(rdwr), ras, cas); /* Only 1 bit will be on */ -- 2.21.0