From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CC62C31E44 for ; Tue, 11 Jun 2019 22:26:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EEDAC20866 for ; Tue, 11 Jun 2019 22:26:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391689AbfFKW0S (ORCPT ); Tue, 11 Jun 2019 18:26:18 -0400 Received: from gate.crashing.org ([63.228.1.57]:56267 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389575AbfFKW0S (ORCPT ); Tue, 11 Jun 2019 18:26:18 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id x5BMPqDC020637; Tue, 11 Jun 2019 17:25:53 -0500 Message-ID: <6df5a17bb1c900dc69b991171e55632f40d9426f.camel@kernel.crashing.org> Subject: Re: [PATCH 2/2] edac: add support for Amazon's Annapurna Labs EDAC From: Benjamin Herrenschmidt To: Borislav Petkov Cc: James Morse , "Hawa, Hanna" , "robh+dt@kernel.org" , "Woodhouse, David" , "paulmck@linux.ibm.com" , "mchehab@kernel.org" , "mark.rutland@arm.com" , "gregkh@linuxfoundation.org" , "davem@davemloft.net" , "nicolas.ferre@microchip.com" , "devicetree@vger.kernel.org" , "Shenhar, Talel" , "linux-kernel@vger.kernel.org" , "Chocron, Jonathan" , "Krupnik, Ronen" , "linux-edac@vger.kernel.org" , "Hanoch, Uri" Date: Wed, 12 Jun 2019 08:25:52 +1000 In-Reply-To: <20190611115651.GD31772@zn.tnic> References: <1559211329-13098-3-git-send-email-hhhawa@amazon.com> <20190531051400.GA2275@cz.tnic> <32431fa2-2285-6c41-ce32-09630205bb54@arm.com> <9a2aaf4a9545ed30568a0613e64bc3f57f047799.camel@kernel.crashing.org> <20190608090556.GA32464@zn.tnic> <1ae5e7a3464f9d8e16b112cd371957ea20472864.camel@kernel.crashing.org> <68446361fd1e742b284555b96b638fe6b5218b8b.camel@kernel.crashing.org> <20190611115651.GD31772@zn.tnic> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Tue, 2019-06-11 at 13:56 +0200, Borislav Petkov wrote: > On Tue, Jun 11, 2019 at 05:21:39PM +1000, Benjamin Herrenschmidt wrote: > > So looking again ... all the registration/removal of edac devices seem > > to already be protected by mutexes, so that's not a problem. > > > > Tell me more about what specific races you think we might have here, > > I'm not sure I follow... > > Well, as I said "it might work or it might set your cat on fire." For > example, one of the error logging paths is edac_mc_handle_error() and > that thing mostly operates using the *mci pointer which should be ok > but then it calls the "trace_mc_event" tracepoint and I'd suppose that > tracepoints can do lockless but I'm not sure. Yes, we would be in a world of pain already if tracepoints couldn't handle concurrency :-) > So what needs to happen is for paths which weren't called by multiple > EDAC agents in parallel but need to get called in parallel now due to > ARM drivers wanting to do that, to get audited that they're safe. That's the thing, I don't think we have such path. We are talking about having separate L1/L2 vs. MC drivers, they don't overlap. > Situation is easy if you have one platform driver where you can > synchronize things in the driver but since you guys need to do separate > drivers for whatever reason, then that would need to be done prior. > > Makes more sense? Sort-of... I still don't see a race in what we propose but I might be missing something subtle. We are talking about two drivers for two different IP blocks updating different counters etc... Cheers, Ben.