From: lvying <lvying6@huawei.com>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: <linux-edac@vger.kernel.org>, <guanyalong@huawei.com>,
<wuyun.wu@huawei.com>, <tanxiaofei@huawei.com>
Subject: Re: [PATCH 1/2] rasdaemon: add rbtree support for page record
Date: Sat, 20 Jun 2020 19:57:25 +0800 [thread overview]
Message-ID: <7c8263e8-0f8f-c4eb-ea20-100aabe24477@huawei.com> (raw)
In-Reply-To: <20200529142433.1cdcb3c8@coco.lan>
>> diff --git a/Makefile.am b/Makefile.am
>> index 843b538..2ff742d 100644
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -17,7 +17,7 @@ all-local: $(SYSTEMD_SERVICES)
>>
>> sbin_PROGRAMS = rasdaemon
>> rasdaemon_SOURCES = rasdaemon.c ras-events.c ras-mc-handler.c \
>> - bitfield.c
>> + bitfield.c rbtree.c
>
> I would move the change at Makefile.am to the next patch.
>
> As I'll comment there, I'd like to have a separate configure
> option for each feature provided by the rasdaemon.
>
> So, I would like to see something like:
>
> if WITH_PG_RECORD
> rasdaemon_SOURCES += rbtree.c ras-page-isolation.c
> endif
>
> at the Makefile.am (after applying both patches)
>
Ok, I will add a configure option(WITH_MEMORY_CE_PFA) to the
configure.ac to isolate this feature. This modification will be moved to
next patch.
--
Thanks!
Lv Ying
next prev parent reply other threads:[~2020-06-20 11:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 8:24 [PATCH 0/2] rasdaemon: add support for memory Corrected Error predictive failure analysis lvying6
2020-05-29 8:24 ` [PATCH 1/2] rasdaemon: add rbtree support for page record lvying6
2020-05-29 12:24 ` Mauro Carvalho Chehab
2020-06-20 11:57 ` lvying [this message]
2020-05-29 8:24 ` [PATCH 2/2] rasdaemon: add support for memory Corrected Error predictive failure analysis lvying6
2020-05-29 14:31 ` Mauro Carvalho Chehab
2020-06-20 11:59 ` lvying
2020-06-20 12:26 ` [PATCH v2 rasdaemon 0/2] support memory CE " lvying6
2020-06-20 12:26 ` [PATCH v2 rasdaemon 1/2] rasdaemon: add rbtree support for page record lvying6
2020-06-20 12:26 ` [PATCH v2 rasdaemon 2/2] rasdaemon: add support for memory Corrected Error predictive failure analysis lvying6
2020-07-21 12:26 ` [PATCH 0/2] " Mauro Carvalho Chehab
-- strict thread matches above, loose matches on Subject: below --
2020-02-24 4:07 lvying
2020-02-24 4:07 ` [PATCH 1/2] rasdaemon: add rbtree support for page record lvying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c8263e8-0f8f-c4eb-ea20-100aabe24477@huawei.com \
--to=lvying6@huawei.com \
--cc=guanyalong@huawei.com \
--cc=linux-edac@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=tanxiaofei@huawei.com \
--cc=wuyun.wu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).