From: "Luck, Tony" <tony.luck@intel.com>
To: Aili Yao <yaoaili@kingsoft.com>, Borislav Petkov <bp@alien8.de>
Cc: "mingo@redhat.com" <mingo@redhat.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"yangfeng1@kingsoft.com" <yangfeng1@kingsoft.com>
Subject: RE: [PATCH v2] x86/mce: fix wrong no-return-ip logic in do_machine_check()
Date: Tue, 23 Feb 2021 16:12:43 +0000 [thread overview]
Message-ID: <9232988079334ab8801cccec6557f9c3@intel.com> (raw)
In-Reply-To: <20210223192711.0b517745@alex-virtual-machine>
> What I think is qemu has not an easy to get the MCE signature from host or currently no methods for this
> So qemu treat all AR will be No RIPV, Do more is better than do less.
RIPV would be important in the guest in the case where the guest can fix the problem that caused
the machine check and return to the failed instruction to continue.
I think the only case where this happens is a fault in a read-only page mapped from a file (typically
code page, but could be a data page). In this case memory-failure() unmaps the page with the posion
but Linux can recover by reading data from the file into a new page.
Other cases we send SIGBUS (so go to the signal handler instead of to the faulting instruction).
So it would be good if the state of RIPV could be added to the signal state sent to qemu. If that
isn't possible, then this full recovery case turns into another SIGBUS case.
-Tony
next prev parent reply other threads:[~2021-02-23 16:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 3:31 x86/mce: fix wrong no-return-ip logic in do_machine_check() Aili Yao
2021-02-22 3:50 ` [PATCH v2] " Aili Yao
2021-02-22 9:24 ` Borislav Petkov
2021-02-22 9:31 ` Aili Yao
2021-02-22 10:03 ` Borislav Petkov
2021-02-22 10:08 ` Aili Yao
2021-02-22 10:22 ` Borislav Petkov
2021-02-22 11:21 ` Aili Yao
2021-02-22 12:17 ` Aili Yao
2021-02-22 12:22 ` Borislav Petkov
2021-02-22 12:35 ` Aili Yao
2021-02-22 12:45 ` Borislav Petkov
2021-02-23 2:27 ` Aili Yao
2021-02-23 9:43 ` Borislav Petkov
2021-02-23 9:56 ` Aili Yao
2021-02-23 10:05 ` Borislav Petkov
2021-02-23 11:27 ` Aili Yao
2021-02-23 16:12 ` Luck, Tony [this message]
2021-02-24 2:39 ` Aili Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9232988079334ab8801cccec6557f9c3@intel.com \
--to=tony.luck@intel.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yangfeng1@kingsoft.com \
--cc=yaoaili@kingsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).