From: Dave Hansen <dave.hansen@intel.com>
To: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@suse.de>,
Andy Lutomirski <luto@kernel.org>,
x86@kernel.org, Tony Luck <tony.luck@intel.com>,
Cathy Zhang <cathy.zhang@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Kyung Min Park <kyung.min.park@intel.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
"Ravi V. Shankar" <ravi.v.shankar@intel.com>,
Sean Christopherson <sean.j.christopherson@intel.com>,
linux-kernel@vger.kernel.org,
Ricardo Neri <ricardo.neri@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
linux-edac@vger.kernel.org
Subject: Re: [PATCH v3] x86/cpu: Use SERIALIZE in sync_core() when available
Date: Thu, 6 Aug 2020 16:08:47 -0700 [thread overview]
Message-ID: <929b76df-7da8-9147-3939-5e044f9d7728@intel.com> (raw)
In-Reply-To: <20200806230455.GA25599@ranerica-svr.sc.intel.com>
On 8/6/20 4:04 PM, Ricardo Neri wrote:
> * CPUID is the conventional way, but it's nasty: it doesn't
> * exist on some 486-like CPUs, and it usually exits to a
> * hypervisor.
> *
> * The SERIALIZE instruction is the most straightforward way to
> * do this as it does not clobber registers or exit to a
> * hypervisor. However, it is not universally available.
> *
> * Like all of Linux's memory ordering operations, this is a
> * compiler barrier as well.
> */
>
> What do you think?
I like what I suggested. :)
SERIALIZE is best where available. Do it first, comment it by itself.
Then, go into the long discussion of the other alternatives. They only
make sense when SERIALIZE isn't there, and the logic for selection there
is substantially more complicated.
next prev parent reply other threads:[~2020-08-06 23:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 19:25 [PATCH v3] x86/cpu: Use SERIALIZE in sync_core() when available Ricardo Neri
2020-08-06 19:57 ` Dave Hansen
2020-08-06 23:04 ` Ricardo Neri
2020-08-06 23:08 ` Dave Hansen [this message]
2020-08-06 23:39 ` Ricardo Neri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=929b76df-7da8-9147-3939-5e044f9d7728@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@suse.de \
--cc=cathy.zhang@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=kyung.min.park@intel.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.v.shankar@intel.com \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=ricardo.neri@intel.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).