From: Sherry Sun <sherry.sun@nxp.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "mchehab@kernel.org" <mchehab@kernel.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"james.morse@arm.com" <james.morse@arm.com>,
"rrichter@marvell.com" <rrichter@marvell.com>,
"michal.simek@xilinx.com" <michal.simek@xilinx.com>,
"manish.narani@xilinx.com" <manish.narani@xilinx.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>, Frank Li <frank.li@nxp.com>
Subject: RE: [PATCH v2] EDAC: synopsys: Fix the wrong call of pinf->col parameter
Date: Mon, 16 Mar 2020 12:28:58 +0000 [thread overview]
Message-ID: <AM6PR04MB6584F064D683493842EE5B4A92F90@AM6PR04MB6584.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200316104356.GH26126@zn.tnic>
Hi Borislav,
> -----Original Message-----
> From: Borislav Petkov <bp@alien8.de>
> Sent: 2020年3月16日 18:44
> To: Sherry Sun <sherry.sun@nxp.com>
> Cc: mchehab@kernel.org; tony.luck@intel.com; james.morse@arm.com;
> rrichter@marvell.com; michal.simek@xilinx.com; manish.narani@xilinx.com;
> linux-edac@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx
> <linux-imx@nxp.com>; Frank Li <frank.li@nxp.com>
> Subject: Re: [PATCH v2] EDAC: synopsys: Fix the wrong call of pinf->col
> parameter
>
> On Mon, Mar 16, 2020 at 01:30:39AM +0000, Sherry Sun wrote:
> > Maybe you misunderstood the handle_error(), this function has already
> > distinguished between Zynq and ZynqMP through priv->p_data->quirks.
> > And what I am doing in this patch is to remove the useless pinf->col
> > in ZynqMP part, which won't break the Zynq part.
>
> Ok, I see it now, thanks for clarifying.
>
> Now, in your v2 pls fix this check in handle_error():
>
> if (!priv->p_data->quirks) {
>
> to *actually* *explicitly* check that the platform for which this function is
> called, really supports interrupts, i.e., DDR_ECC_INTR_SUPPORT, and not that
> the ->quirks thing is != 0. Like the rest of the code does.
>
Ok, I will fix this check.
Best regards
Sherry Sun
> Thx.
>
> --
> Regards/Gruss,
> Boris.
>
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpeopl
> e.kernel.org%2Ftglx%2Fnotes-about-
> netiquette&data=02%7C01%7Csherry.sun%40nxp.com%7Ccd843239ffd
> d48a05ce408d7c996ebd5%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C
> 0%7C637199522356909838&sdata=5p6JuXQQJgyjlaMOUH1cLLSDFbUzM
> R%2Fjzs5HC%2FeU1Zc%3D&reserved=0
prev parent reply other threads:[~2020-03-16 12:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 2:16 [PATCH v2] EDAC: synopsys: Fix the wrong call of pinf->col parameter Sherry Sun
2020-03-09 8:44 ` Manish Narani
2020-03-15 19:50 ` Borislav Petkov
2020-03-16 1:30 ` Sherry Sun
2020-03-16 10:43 ` Borislav Petkov
2020-03-16 12:28 ` Sherry Sun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR04MB6584F064D683493842EE5B4A92F90@AM6PR04MB6584.eurprd04.prod.outlook.com \
--to=sherry.sun@nxp.com \
--cc=bp@alien8.de \
--cc=frank.li@nxp.com \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manish.narani@xilinx.com \
--cc=mchehab@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=rrichter@marvell.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).