Linux-EDAC Archive on lore.kernel.org
 help / color / Atom feed
From: Naoto YAMAGUCHI <wata2ki@gmail.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-edac@vger.kernel.org,
	Naoto Yamaguchi <i33399_YAMAGUCHI@aisin-aw.co.jp>
Subject: Re: [PATCH] EDAC/mc: Fix memory alignment calculation formula
Date: Wed, 3 Jun 2020 22:07:36 +0900
Message-ID: <CABBJnRaLTT_B_-mdfQum0dcaNvvEadQMucT94wp+7t12GjTx9A@mail.gmail.com> (raw)
In-Reply-To: <20200603112816.GC19711@zn.tnic>

Hi

Out of tree driver (edac_injection) is under developing now by
Gabriele Paoloni.  This driver will upstream future.

When I was porting this driver to aarch64 environment, I found this bug.

This bug is also common bug for other edac me drivers.  My opinion,
this bug should be fixed instead of waiting for the driver to be
developed.
Because alignment miss may only cause performance degradation in case
of Intel, but it cause CPU exceptions (Oops/kernel panic) in case of
aarch64 and other risc like architecture.

This bug was supposed to be fixed in commit(a).
But this fix conflict with the commit(b) fix and consequently the bug
was not fixed.

commit(a): https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/edac/edac_mc.c?h=linux-3.7.y&id=8447c4d15e357a458c9051ddc84aa6c8b9c27000
commit(b): https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/edac/edac_mc.c?h=linux-3.7.y&id=93e4fe64ece4eccf0ff4ac69bceb389290b8ab7c

Thanks

2020年6月3日(水) 20:28 Borislav Petkov <bp@alien8.de>:
>
> On Sun, May 17, 2020 at 01:21:15AM +0900, wata2ki wrote:
> > From: Naoto Yamaguchi <i33399_YAMAGUCHI@aisin-aw.co.jp>
> >
> > During the development of the off-tree driver,
>
> Wait, what?
>
> Am I reading this correctly that you have an out-of-tree EDAC driver?
>
> If so, why? Why not submit it upstream?
>
> Thx.
>
> --
> Regards/Gruss,
>     Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette

  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-16 16:21 wata2ki
2020-06-03 11:28 ` Borislav Petkov
2020-06-03 13:07   ` Naoto YAMAGUCHI [this message]
     [not found]   ` <CABBJnRYZTsnOjNdd9x5ZS_Vb56yvEJWsLxEERYPj-m3HfAqx1Q@mail.gmail.com>
2020-06-03 17:36     ` Borislav Petkov
2020-06-17 17:58 ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABBJnRaLTT_B_-mdfQum0dcaNvvEadQMucT94wp+7t12GjTx9A@mail.gmail.com \
    --to=wata2ki@gmail.com \
    --cc=bp@alien8.de \
    --cc=i33399_YAMAGUCHI@aisin-aw.co.jp \
    --cc=linux-edac@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-EDAC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-edac/0 linux-edac/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-edac linux-edac/ https://lore.kernel.org/linux-edac \
		linux-edac@vger.kernel.org
	public-inbox-index linux-edac

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-edac


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git