From: Tyler Baicar <baicar.tyler@gmail.com>
To: James Morse <james.morse@arm.com>
Cc: wufan <wufan@codeaurora.org>,
mchehab@kernel.org, Borislav Petkov <bp@alien8.de>,
linux-edac@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
arm-mail-list <linux-arm-kernel@lists.infradead.org>
Subject: EDAC, ghes: use CPER module handles to locate DIMMs
Date: Thu, 30 Aug 2018 12:46:10 -0400 [thread overview]
Message-ID: <CABo9ajDf09BHsq0NOs99NSD6zOV5N-CDvgvQrGi9p_wLjpJ24g@mail.gmail.com> (raw)
On Thu, Aug 30, 2018 at 12:32 PM, James Morse <james.morse@arm.com> wrote:
> Hi Fan,
>
> On 30/08/18 15:40, wufan wrote:
>>>> @@ -327,12 +349,20 @@ void ghes_edac_report_mem_error(int sev,
>>> struct cper_sec_mem_err *mem_err)
>>>> p += sprintf(p, "bit_pos:%d ", mem_err->bit_pos);
>>>> if (mem_err->validation_bits &
>>> CPER_MEM_VALID_MODULE_HANDLE) {
>>>> const char *bank = NULL, *device = NULL;
>>>> + int index = -1;
>>>> +
>>>> dmi_memdev_name(mem_err->mem_dev_handle, &bank,
>>> &device);
>>>
>>>> + p += sprintf(p, "DIMM DMI handle: 0x%.4x ",
>>>> + mem_err->mem_dev_handle);
>>>> if (bank != NULL && device != NULL)
>>>> p += sprintf(p, "DIMM location:%s %s ", bank, device);
>>>> - else
>>>> - p += sprintf(p, "DIMM DMI handle: 0x%.4x ",
>>>> - mem_err->mem_dev_handle);
>>>
>>> Why do we now print the handle every time? The handle is pretty
>>> meaningless, it can only be used to find the location-strings, if we get those
>>> we print them instead.
>>
>> For ghes_edac the bank/device is informational, and nothing would go wrong
>> if the bank/device numbers are the same as another entry. But the handle
>> is now critical for DIMM lookup, thus pull it out.
>
> Is printing the handle to the kernel log critical?
>
I don't see why we would need this print. The bank/device
print is enough to map what is shown in dmesg to an SMBIOS
entry if that's really needed.
Thanks,
Tyler
next reply other threads:[~2018-08-30 16:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 16:46 Tyler Baicar [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-09-03 19:18 EDAC, ghes: use CPER module handles to locate DIMMs Borislav Petkov
2018-09-03 15:05 wufan
2018-08-31 10:06 tanxiaofei
2018-08-30 17:11 wufan
2018-08-30 16:50 John Garry
2018-08-30 16:45 wufan
2018-08-30 16:34 James Morse
2018-08-30 16:34 James Morse
2018-08-30 16:32 James Morse
2018-08-30 15:12 Borislav Petkov
2018-08-30 14:40 wufan
2018-08-30 14:20 wufan
2018-08-30 10:48 James Morse
2018-08-30 10:43 Borislav Petkov
2018-08-29 18:33 wufan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABo9ajDf09BHsq0NOs99NSD6zOV5N-CDvgvQrGi9p_wLjpJ24g@mail.gmail.com \
--to=baicar.tyler@gmail.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=wufan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).