From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 119CDC43461 for ; Mon, 14 Sep 2020 06:39:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A67B721548 for ; Mon, 14 Sep 2020 06:39:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=jms.id.au header.i=@jms.id.au header.b="KM43qRmI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726043AbgINGjL (ORCPT ); Mon, 14 Sep 2020 02:39:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726042AbgINGjE (ORCPT ); Mon, 14 Sep 2020 02:39:04 -0400 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73A7CC06174A; Sun, 13 Sep 2020 23:39:04 -0700 (PDT) Received: by mail-ej1-x643.google.com with SMTP id p9so21544220ejf.6; Sun, 13 Sep 2020 23:39:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tM1rt0vCMPBG29FozlgK4tPcKJfgi5TlJoa0v0rD7zo=; b=KM43qRmICDk1SaQ1VXMUHX+8tngtm6ts9le/JiSXTFcxsA4Rn545KbrS6sbua4lvB6 55oFrksVPZKrTSkYogsSedq0HvH+7BnTvkNsKjTX8YbbnNv9LWYp3KAOZuNYjrzekkso g15xcuUW7Pp9ctrMAJdkZx7E67oOI6E/iPPjc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tM1rt0vCMPBG29FozlgK4tPcKJfgi5TlJoa0v0rD7zo=; b=KNVSjCN7ZvwMEMSnACwEtj2+0FaCFzkqlEFoabrb6IOhJ2dGWGpGqJByenjSiIrKSn UslM1N9dYm+xRarFg9hxqQQZ3CRs4x53Tu/g8LFPA6eOv4kXTvVrsfDYSz2LnqYbyMg4 Uv5Ua9SAvODNa1ejxax34yM04SAvVxMlYRDjw3Mz+GcU/NxPrSnNkDdzSXmzdy2cM51Y xLgzj5/T+UGogReeasrtwT7AvHDTnkzpcfj2cK4kwQ08sQ4ujqJmEiurQcS4j7oD+9fU nXyZr/rO5WM1W3hCZOGfFrmnvNx6Nc2hAE4TU70Zqe3Hpsiv/Kvs8l4SNjyPEUvIQPVp Fzrw== X-Gm-Message-State: AOAM532eUTiK8h6pIJ3WcpMl1WXwSv+oDGWKNzB1rmRP4d9nuiOOolnj aEvOI3N259ToREnIqB3DbmgdJjADh56lvDE1oGE= X-Google-Smtp-Source: ABdhPJzrrj2gAuLbkZT1NZHl72TkCiS8KlLa+esbZG3y0tjiUqQYdjdE8GIcrDf9ZRv0CeN9WMiieM2monhZa1/DE5s= X-Received: by 2002:a17:906:4c58:: with SMTP id d24mr13673692ejw.108.1600065543130; Sun, 13 Sep 2020 23:39:03 -0700 (PDT) MIME-Version: 1.0 References: <20200914065358.3726216-1-liushixin2@huawei.com> In-Reply-To: <20200914065358.3726216-1-liushixin2@huawei.com> From: Joel Stanley Date: Mon, 14 Sep 2020 06:38:50 +0000 Message-ID: Subject: Re: [PATCH -next] EDAC/aspeed: use module_platform_driver to simplify the code To: Liu Shixin Cc: Stefan Schaeckeler , Borislav Petkov , Mauro Carvalho Chehab , Tony Luck , James Morse , Robert Richter , Andrew Jeffery , linux-edac@vger.kernel.org, Linux ARM , linux-aspeed , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Mon, 14 Sep 2020 at 06:31, Liu Shixin wrote: > > module_platform_driver() makes the code simpler by eliminating > boilerplate code. > > Signed-off-by: Liu Shixin Reviewed-by: Joel Stanley > --- > drivers/edac/aspeed_edac.c | 18 +----------------- > 1 file changed, 1 insertion(+), 17 deletions(-) > > diff --git a/drivers/edac/aspeed_edac.c b/drivers/edac/aspeed_edac.c > index fbec28dc661d..fde809efc520 100644 > --- a/drivers/edac/aspeed_edac.c > +++ b/drivers/edac/aspeed_edac.c > @@ -388,23 +388,7 @@ static struct platform_driver aspeed_driver = { > .probe = aspeed_probe, > .remove = aspeed_remove > }; > - > - > -static int __init aspeed_init(void) > -{ > - return platform_driver_register(&aspeed_driver); > -} > - > - > -static void __exit aspeed_exit(void) > -{ > - platform_driver_unregister(&aspeed_driver); > -} > - > - > -module_init(aspeed_init); > -module_exit(aspeed_exit); > - > +module_platform_driver(aspeed_driver); > > MODULE_LICENSE("GPL"); > MODULE_AUTHOR("Stefan Schaeckeler "); > -- > 2.25.1 >