Linux-EDAC Archive on lore.kernel.org
 help / color / Atom feed
From: Rob Herring <robh@kernel.org>
To: "Hawa, Hanna" <hhhawa@amazon.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Borislav Petkov <bp@alien8.de>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	James Morse <james.morse@arm.com>,
	David Miller <davem@davemloft.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	"Paul E. McKenney" <paulmck@linux.ibm.com>,
	"Woodhouse, David" <dwmw@amazon.co.uk>,
	benh@amazon.com, "Krupnik, Ronen" <ronenk@amazon.com>,
	Talel Shenhar <talel@amazon.com>,
	Jonathan Chocron <jonnyc@amazon.com>,
	"Hanoch, Uri" <hanochu@amazon.com>,
	devicetree@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-edac <linux-edac@vger.kernel.org>
Subject: Re: [PATCH v5 1/4] dt-bindings: EDAC: Add Amazon's Annapurna Labs L1 EDAC
Date: Tue, 27 Aug 2019 08:49:13 -0500
Message-ID: <CAL_Jsq+8jGbR4u7FA8r0gP5i2H+nSgOkGU_5mfiL=i=c0sOW8A@mail.gmail.com> (raw)
In-Reply-To: <1d23d7c5-cd7b-1512-5300-d43e82ba6dc1@amazon.com>

On Mon, Aug 26, 2019 at 9:49 AM Hawa, Hanna <hhhawa@amazon.com> wrote:
>
>
>
> On 8/21/2019 10:17 PM, Rob Herring wrote:
> > Why is this even in DT? AFAICT, this is all just CortexA57 core features
> > (i.e. nothing Amazon specific). The core type and the ECC capabilities
> > are discoverable.
>
> Added to the DT in order to easily enable/disable the driver.

That alone is not reason enough to put it in DT. From a DT
perspective, I have no idea what the whims of a OS maintainer are
regarding whether they want all this to be 1 driver or 2 drivers.
(IMO, it should be 1 as this is ECC for an A57. For a core and memory
controller, then 2 seems appropriate.)

> You are
> correct that they are CortexA57 core features and nothing Amazon
> specific, but it's IMPLEMENTATION DEFINED, meaning that in different
> cortex revisions (e.g. A57) the register bitmap may change. Because of
> that we added an Amazon compatible which corresponds to the specific
> core we are using.

'IMPLEMENTATION DEFINED' usually means not defined by the
architecture. This doesn't seem like something that's going to change
with A57 revisions. Plus, the A57 is pretty old now, so we know what's
out there already. In any case, the revision is discoverable too, so
we could deal with changes between revisions in any case.

Rob

  reply index

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-05 14:39 [PATCH v5 0/4] Add support for Amazon's Annapurna Labs EDAC for L1/L2 Hanna Hawa
2019-08-05 14:39 ` [PATCH v5 1/4] dt-bindings: EDAC: Add Amazon's Annapurna Labs L1 EDAC Hanna Hawa
2019-08-21 19:17   ` Rob Herring
2019-08-26 14:49     ` Hawa, Hanna
2019-08-27 13:49       ` Rob Herring [this message]
2019-08-30 12:45         ` James Morse
2019-08-30 21:50           ` Rob Herring
2019-09-06 16:28             ` James Morse
2019-08-05 14:39 ` [PATCH v5 2/4] edac: Add support for " Hanna Hawa
2019-08-05 14:39 ` [PATCH v5 3/4] dt-bindings: EDAC: Add Amazon's Annapurna Labs L2 EDAC Hanna Hawa
2019-08-05 14:39 ` [PATCH v5 4/4] edac: Add support for " Hanna Hawa

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL_Jsq+8jGbR4u7FA8r0gP5i2H+nSgOkGU_5mfiL=i=c0sOW8A@mail.gmail.com' \
    --to=robh@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=benh@amazon.com \
    --cc=bp@alien8.de \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw@amazon.co.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=hanochu@amazon.com \
    --cc=hhhawa@amazon.com \
    --cc=james.morse@arm.com \
    --cc=jonnyc@amazon.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=paulmck@linux.ibm.com \
    --cc=ronenk@amazon.com \
    --cc=talel@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-EDAC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-edac/0 linux-edac/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-edac linux-edac/ https://lore.kernel.org/linux-edac \
		linux-edac@vger.kernel.org linux-edac@archiver.kernel.org
	public-inbox-index linux-edac

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-edac


AGPL code for this site: git clone https://public-inbox.org/ public-inbox