From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAF53C73C53 for ; Tue, 9 Jul 2019 15:48:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F49421670 for ; Tue, 9 Jul 2019 15:48:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562687308; bh=8uRt2LckP8V6eOMg2L1MMuumGINZ1eU0bTBj8g3A81c=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=k/WmkRH2vkQv8iOz08CdLdVdufFZSIIrQyHYj3pC7UEhz62C/od8oDj1L9QxuCt3p 55q8DlikAlwMex54Zh0wmHJMXsA17K29dpx9XoWxnY0kXQ3AEbzM+7avQY06hvNhQ6 d0jaO4KJ3LkcTpT5/agrkGfZOgf3lLynO61g8tJQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726229AbfGIPs2 (ORCPT ); Tue, 9 Jul 2019 11:48:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:40216 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726060AbfGIPs2 (ORCPT ); Tue, 9 Jul 2019 11:48:28 -0400 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B3E7721743; Tue, 9 Jul 2019 15:48:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562687306; bh=8uRt2LckP8V6eOMg2L1MMuumGINZ1eU0bTBj8g3A81c=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=KON4ngr4Z1oJj/l8kSJhRwNeUk2R1NwwJID4TkmcPIl+MyUHNX7S9wJWmLi5kcXKR 9yQxDgx12Pr9RsOFxewTO1k23CslxM8Urly5NjQV84pjT6TLgiu+KpOv98L6F8TVW0 OXrssDvfqBv5JToN0eDMoLBPFu4Trx+79enV2b4E= Received: by mail-qt1-f169.google.com with SMTP id h18so14673216qtm.9; Tue, 09 Jul 2019 08:48:26 -0700 (PDT) X-Gm-Message-State: APjAAAUBtqYLDPGN0x+RA9MmxX6sGsFbECumxVvTNbQEZvJTMgaDU/n7 spKsZz3u9SM/9FbyWgBKX43YQ61fZd4CvDhPeA== X-Google-Smtp-Source: APXvYqwUwZzNp9+krU8sgcmMHMgX3VqOxwtH/223QreLrdzSam3oenUJ5tLIk/dBBxOlEo8N5HAE7gFB0xXhMGeAItk= X-Received: by 2002:ac8:3908:: with SMTP id s8mr19233318qtb.224.1562687305930; Tue, 09 Jul 2019 08:48:25 -0700 (PDT) MIME-Version: 1.0 References: <20190605141253.38554-1-ghung.quanta@gmail.com> <20190605141253.38554-2-ghung.quanta@gmail.com> <20190709014058.GA30269@bogus> <0c90f9376c0e425c9a226379f7e5bfad@quantatw.com> In-Reply-To: <0c90f9376c0e425c9a226379f7e5bfad@quantatw.com> From: Rob Herring Date: Tue, 9 Jul 2019 09:48:14 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 5.2 v2 2/2] dt-binding: edac: add NPCM ECC documentation To: =?UTF-8?B?R2VvcmdlIEh1bmcgKOa0quW/oOaVrCk=?= Cc: George Hung , Mark Rutland , Linus Walleij , Tali Perry , "paulmck@linux.ibm.com" , "wak@google.com" , "benjaminfair@google.com" , "openbmc@lists.ozlabs.org" , "tomer.maimon@nuvoton.com" , "devicetree@vger.kernel.org" , Borislav Petkov , "Avi.Fishman@nuvoton.com" , Jonathan Cameron , Mauro Carvalho Chehab , linux-edac , Patrick Venture , Nicolas Ferre , linux-kernel , James Morse , Greg Kroah-Hartman , "davem@davemloft.net" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Tue, Jul 9, 2019 at 3:50 AM George Hung (=E6=B4=AA=E5=BF=A0=E6=95=AC) wrote: > > Hi Rob, > > > > -----Original Message----- > > From: openbmc > > [mailto:openbmc-bounces+george.hung=3Dquantatw.com@lists.ozlabs.org] On > > Behalf Of Rob Herring > > Sent: Tuesday, July 09, 2019 9:41 AM > > To: George Hung > > Cc: Mark Rutland; Linus Walleij; Tali Perry; paulmck@linux.ibm.com; > > wak@google.com; benjaminfair@google.com; openbmc@lists.ozlabs.org; > > tomer.maimon@nuvoton.com; devicetree@vger.kernel.org; Borislav Petkov; > > Avi.Fishman@nuvoton.com; Jonathan Cameron; Mauro Carvalho Chehab; > > linux-edac; Patrick Venture; Nicolas Ferre; linux-kernel; James Morse; = Greg > > Kroah-Hartman; davem@davemloft.net > > Subject: Re: [PATCH 5.2 v2 2/2] dt-binding: edac: add NPCM ECC > > documentation > > > > On Wed, Jun 05, 2019 at 10:12:53PM +0800, George Hung wrote: > > > Add device tree documentation for Nuvoton BMC ECC > > > > > > Signed-off-by: George Hung > > > --- > > > .../bindings/edac/npcm7xx-sdram-edac.txt | 17 > > +++++++++++++++++ > > > 1 file changed, 17 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindings/edac/npcm7xx-sdram-edac.txt > > > > > > diff --git > > > a/Documentation/devicetree/bindings/edac/npcm7xx-sdram-edac.txt > > > b/Documentation/devicetree/bindings/edac/npcm7xx-sdram-edac.txt > > > new file mode 100644 > > > index 000000000000..dd4dac59a5bd > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/edac/npcm7xx-sdram-edac.txt > > > @@ -0,0 +1,17 @@ > > > +Nuvoton NPCM7xx SoC EDAC device driver > > > + > > > +The Nuvoton NPCM7xx SoC supports DDR4 memory with/without ECC and > > the > > > +driver uses the EDAC framework to implement the ECC detection and > > corrtection. > > > + > > > +Required properties: > > > +- compatible: should be "nuvoton,npcm7xx-sdram-edac" > > > > Is this for the whole SDRAM controller or just ECC related registers? > > In the former case, the naming should just reflect the block name and n= ot a > > Linux term. > > Sorry for confused naming, the address space is for the whole memory cont= roller registers indeed, > but the driver only uses the ECC related registers. > Should I change the name to "nuvoton,npcm7xx-edac" ? No, you should drop the 'edac' part. The DT describes the h/w, not what one driver (currently) uses. Rob