From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26563C47420 for ; Wed, 23 Sep 2020 18:25:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DBFB42395A for ; Wed, 23 Sep 2020 18:25:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600885504; bh=PQ694416mkyRJSudKeRj8BUutkY/M7TaA4klpl4VyS4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=xLw+FHKs7r49Q/hMTzwHRFgKBhvDzFcrmjop1XAYds7qY+8r1oEcHBtAXaDPQ2MFl NOaIUFL8Vv+0lETxn09Sk8i4TB3ZkbglxW5TMEi6LeTh67nhQ5UrLl7xasZoaB6sYY 1uqUE5VztaCIwJcq8os+TWNYoxmg98Tl1/OQ/IhQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726693AbgIWSZB (ORCPT ); Wed, 23 Sep 2020 14:25:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:34278 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726419AbgIWSZB (ORCPT ); Wed, 23 Sep 2020 14:25:01 -0400 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 44C0323772; Wed, 23 Sep 2020 18:25:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600885500; bh=PQ694416mkyRJSudKeRj8BUutkY/M7TaA4klpl4VyS4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Sp25cRCfXBwQvz8IEVyYDCihyBlbXyN9B/1NISrGs9y+1srSW97VOmUQ/DE41EM0C KvIwFSmNAZVLn5+WIb1cgtc1+M9/AGEhma8J+L2VwYv8Zhv5JJSifOvibXDbjv7L/B zavBT3QAfrCIoTHAYA6lJ94iYn6voP9ghpnPrRQY= Received: by mail-ot1-f41.google.com with SMTP id h17so697446otr.1; Wed, 23 Sep 2020 11:25:00 -0700 (PDT) X-Gm-Message-State: AOAM531jwKoa99XqRDfVN3FFGQQQl4Ur4isnYiE3LrvozmVWPq/SRHp/ Gd0SGQf+8Hb3TWvj3UakWvrXBYXnuumagxhQLSQ= X-Google-Smtp-Source: ABdhPJy9WdySVafg27Wj/nNe1H0VU72po5OOABeeZP3D0Di8Jb0nGEdDJw+uU/MGCnmXwce3EztKeBoH4saGj0jKFD8= X-Received: by 2002:a9d:6250:: with SMTP id i16mr677534otk.77.1600885499444; Wed, 23 Sep 2020 11:24:59 -0700 (PDT) MIME-Version: 1.0 References: <20200904140444.161291-1-Smita.KoralahalliChannabasappa@amd.com> <87wo0kiz6y.fsf@kokedama.swc.toshiba.co.jp> <20200923140512.GJ28545@zn.tnic> <20200923153941.GK28545@zn.tnic> In-Reply-To: <20200923153941.GK28545@zn.tnic> From: Ard Biesheuvel Date: Wed, 23 Sep 2020 20:24:48 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4] cper, apei, mce: Pass x86 CPER through the MCA handling chain To: Borislav Petkov Cc: Punit Agrawal , Smita Koralahalli , X86 ML , Linux Kernel Mailing List , linux-pm@vger.kernel.org, linux-edac@vger.kernel.org, linux-efi , ACPI Devel Maling List , devel@acpica.org, Tony Luck , "Rafael J . Wysocki" , Len Brown , Yazen Ghannam Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Wed, 23 Sep 2020 at 17:39, Borislav Petkov wrote: > > On Wed, Sep 23, 2020 at 04:52:18PM +0200, Ard Biesheuvel wrote: > > I think the question is why we are retaining this Reported-by header > > to begin with. Even though the early feedback is appreciated, > > crediting the bot for eternity for a version of the patch that never > > got merged seems a bit excessive. Also, it may suggest that the bot > > was involved in reporting an issue that the patch aims to fix but that > > is not the case. > > That is supposed to be explained in [] properly so that there's no > misreading of why that tag's there. > > > The last thing we want is Sasha's bot to jump on patches adding new > > functionality just because it has a reported-by line. > > It should jump on patches which have Fixes: tags. But Sasha's bot is > nuts regardless. :-) > > > So I suggest dropping the Reported-by credit as well as the [] context > > regarding v1 > > So I don't mind having a Reported-by: tag with an explanation of what > it reported. We slap all kinds of tags so having some attribution for > the work the 0day bot does to catch such errors is reasonable. I presume > they track this way how "useful" it is, by counting the Reported-by's or > so, as they suggest one should add a Reported-by in their reports. > > And without any attribution what the 0day bot reported, it might decide > not to report anything next time, I'd venture a guess. > > And the same argument can be had for Suggested-by: tags: one could > decide not to add that tag and the person who's doing the suggesting > might decide not to suggest anymore. > > So I think something like: > > [ Fix a build breakage in an earlier version. ] > Reported-by: 0day bot > > is fine as long as it makes it perfectly clear what Reported-by tag > is for and as long as ts purpose for being present there is clear, I > don't see an issue... > I don't think it adds much value tbh, but I am not going to obsess about it either.