From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5436DC433E2 for ; Tue, 15 Sep 2020 18:49:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C03521655 for ; Tue, 15 Sep 2020 18:49:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600195788; bh=StDm87/zyOd2umJ/sexVghFCRbZDPQt3dL4BEakYh40=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=SrYiNlDpkyHFc0Cqg/vvI5DK9nRsXLeXynEWT8+8r5hGfZvCEU6iQdUIx9SX62rga NUQusTcOpsDXns7OfT2MIEd8os2rIeAmPWSrmJ7fZw6i5n+3L6fl+sDbPx+k4V1aq6 6KXtlczuhzSi4iJphh0Vpi08EJWdlY780zn6wUNc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727721AbgIOSto (ORCPT ); Tue, 15 Sep 2020 14:49:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:52826 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727778AbgIORZa (ORCPT ); Tue, 15 Sep 2020 13:25:30 -0400 Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9B09820936; Tue, 15 Sep 2020 17:12:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600189962; bh=StDm87/zyOd2umJ/sexVghFCRbZDPQt3dL4BEakYh40=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=GzcLW9Y77a4vDzQijYHwWGzMS+XnNp0YArQ3N9OD55f1SyTYjZ7GCxlE1fq1cr35O 8e1+K+v8r+oMkaCF+f4E7f7MpT80Dlw1UbjGvDhNKM+fSH/WIs0fXqVB2TInUNo109 1Qtz+MdBfF2WHY94jZxG7VAMma+cV5xguhDnkLwU= Received: by mail-oi1-f176.google.com with SMTP id a3so4734107oib.4; Tue, 15 Sep 2020 10:12:42 -0700 (PDT) X-Gm-Message-State: AOAM531p6fe45OCYN3yUJjHAl4qVLe0ZswI9jB7wr7Oc4xWRuMiCeIcO wRtupMzBkBm+5XLLM3cMVOidUqieYvFGp6rMSko= X-Google-Smtp-Source: ABdhPJwphFyJiA6ONEAftklqagXUydttPtaS/St/C72DhZIjAxdr6tPs+g71Yc+C35YTfy4TfqaIa+nI1jOWU5h5I1w= X-Received: by 2002:aca:d845:: with SMTP id p66mr274454oig.47.1600189961908; Tue, 15 Sep 2020 10:12:41 -0700 (PDT) MIME-Version: 1.0 References: <20200819143544.155096-1-alex.kluver@hpe.com> <20200819143544.155096-2-alex.kluver@hpe.com> <20200915163312.GO14436@zn.tnic> In-Reply-To: From: Ard Biesheuvel Date: Tue, 15 Sep 2020 20:12:31 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/2] edac,ghes,cper: Add Row Extension to Memory Error Record To: Borislav Petkov Cc: Alex Kluver , linux-edac@vger.kernel.org, linux-efi , Linux Kernel Mailing List , mchehab@kernel.org, russ.anderson@hpe.com, Dimitri Sivanich , kluveralex@gmail.com Content-Type: text/plain; charset="UTF-8" Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Tue, 15 Sep 2020 at 20:07, Ard Biesheuvel wrote: > > On Tue, 15 Sep 2020 at 19:33, Borislav Petkov wrote: > > > > On Wed, Aug 19, 2020 at 09:35:43AM -0500, Alex Kluver wrote: > > > Memory errors could be printed with incorrect row values since the DIMM > > > size has outgrown the 16 bit row field in the CPER structure. UEFI > > > Specification Version 2.8 has increased the size of row by allowing it to > > > use the first 2 bits from a previously reserved space within the structure. > > > > > > When needed, add the extension bits to the row value printed. > > > > > > Based on UEFI 2.8 Table 299. Memory Error Record > > > > > > Reviewed-by: Kyle Meyer > > > Reviewed-by: Steve Wahl > > > Tested-by: Russ Anderson > > > Signed-off-by: Alex Kluver > > > --- > > > > > > v1 -> v2: > > > * Add static inline cper_get_mem_extension() to make it > > > more readable, as suggested by Borislav Petkov. > > > > > > * Add second patch for bank field, bank group, and chip id. > > > > > > --- > > > drivers/edac/ghes_edac.c | 8 ++++++-- > > > drivers/firmware/efi/cper.c | 9 +++++++-- > > > include/linux/cper.h | 16 ++++++++++++++-- > > > 3 files changed, 27 insertions(+), 6 deletions(-) > > > > For the EDAC bits: > > > > Acked-by: Borislav Petkov > > > > Also, I could take both through the EDAC tree, if people prefer. > > > > I'll take this via the EFI tree - I was just preparing the branch for > a PR anyways. Alex - these patches do not apply cleanly. Could you please respin them on top of the next branch in https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git? Boris - do you anticipate any conflicts? If so, please take these via the EDAC tree - the CPER code is mostly self contained so I don't expect any conflicts with the EFI tree in that case.