From: Borislav Petkov <bp@alien8.de>
To: Bixuan Cui <cuibixuan@huawei.com>
Cc: kristo@kernel.org, mchehab@kernel.org, tony.luck@intel.com,
linux-edac@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next v2] EDAC: ti: Add missing MODULE_DEVICE_TABLE
Date: Fri, 14 May 2021 12:22:57 +0200 [thread overview]
Message-ID: <YJ5PgRDG9OZ4msyJ@zn.tnic> (raw)
In-Reply-To: <20210512033727.26701-1-cuibixuan@huawei.com>
On Wed, May 12, 2021 at 11:37:27AM +0800, Bixuan Cui wrote:
> The module misses MODULE_DEVICE_TABLE() for of_device_id tables
> and thus never autoloads on ID matches.
> Add the missing declarations.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
> ---
> Changes v2:
> * Modify the commit message to make it more suitable.
>
> drivers/edac/ti_edac.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/edac/ti_edac.c b/drivers/edac/ti_edac.c
> index e7eae20f83d1..169f96e51c29 100644
> --- a/drivers/edac/ti_edac.c
> +++ b/drivers/edac/ti_edac.c
> @@ -197,6 +197,7 @@ static const struct of_device_id ti_edac_of_match[] = {
> { .compatible = "ti,emif-dra7xx", .data = (void *)EMIF_TYPE_DRA7 },
> {},
> };
> +MODULE_DEVICE_TABLE(of, ti_edac_of_match);
>
> static int _emif_get_id(struct device_node *node)
> {
> --
Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2021-05-14 10:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 3:37 [PATCH -next v2] EDAC: ti: Add missing MODULE_DEVICE_TABLE Bixuan Cui
2021-05-14 10:22 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJ5PgRDG9OZ4msyJ@zn.tnic \
--to=bp@alien8.de \
--cc=cuibixuan@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).