From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0F4DC433ED for ; Wed, 5 May 2021 21:04:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A48C613F3 for ; Wed, 5 May 2021 21:04:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232171AbhEEVFr (ORCPT ); Wed, 5 May 2021 17:05:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230329AbhEEVFq (ORCPT ); Wed, 5 May 2021 17:05:46 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BC6CC061574; Wed, 5 May 2021 14:04:50 -0700 (PDT) Received: from zn.tnic (p200300ec2f0b0700e564ac8d2a0c80af.dip0.t-ipconnect.de [IPv6:2003:ec:2f0b:700:e564:ac8d:2a0c:80af]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id EB98D1EC03E4; Wed, 5 May 2021 23:04:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1620248687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=sFKStqMTp87LYvLhL4y5JagHNHCcA1psQUaO5LXStq4=; b=FB6zP19Q4DqHwlMSA3f1aaFAjjOmc5byZ7ZuIZYxXNvDN0eJSvDtM/To7ZoK8lwiy/8Nx7 7FBP5PK1YJkwJTBQG7X22HfPil3rP1/n6VUe/2TJgGUimIqK+IwqhLG0TJOOzM+Bybo9ay oycO7L7VuQ4ncXbIq0RNiHnGq6MtMmY= Date: Wed, 5 May 2021 23:04:44 +0200 From: Borislav Petkov To: Tyler Hicks Cc: wangglei , "Lei Wang (DPLAT)" , "mchehab@kernel.org" , "tony.luck@intel.com" , "james.morse@arm.com" , "rric@kernel.org" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Hang Li , Brandon Waller Subject: Re: [EXTERNAL] Re: [PATCH] EDAC: update edac printk wrappers to use printk_ratelimited. Message-ID: References: <20210505173027.78428-1-wangglei@gmail.com> <20210505202357.GC4967@sequoia> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210505202357.GC4967@sequoia> Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Wed, May 05, 2021 at 03:23:57PM -0500, Tyler Hicks wrote: > Would it be any more acceptable to add an > edac_mc_printk_ratelimited() macro, which uses printk_ratelimited(), > and then call that new macro from edac_ce_error()? You guys are way off here: the intent of EDAC drivers is to accurately report errors for purposes of counting them and doing analysis on that collected data as to whether components are going wrong - not to ratelimit them as some nuisance output. With breaking the EDAC reporting, you're barking up the wrong tree - if you don't want to see those errors, do not load the drivers. It is that simple. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette