From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F147C4707F for ; Tue, 25 May 2021 20:12:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 04907611C2 for ; Tue, 25 May 2021 20:12:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231557AbhEYUOX (ORCPT ); Tue, 25 May 2021 16:14:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230222AbhEYUOW (ORCPT ); Tue, 25 May 2021 16:14:22 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A66C5C061574; Tue, 25 May 2021 13:12:52 -0700 (PDT) Received: from zn.tnic (p200300ec2f0c1b002e9a6969de3a19f0.dip0.t-ipconnect.de [IPv6:2003:ec:2f0c:1b00:2e9a:6969:de3a:19f0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 95EB71EC0249; Tue, 25 May 2021 22:12:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1621973570; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=0oczzyVicJSWXsQMSbTAEPrWE1pjbktvObtdG3YBcsA=; b=IbCyWqriver8SMcwlr5ltJeBrU1OL7CN56C99mmkZp6ltV97+p/oZeCw8/05Et4zXvg3fb +2HoFrqsIpn8NejWNAR3CGTkcklmYzTXKwcu6M1MuEsnpeWzMIJsMmrxfAkvxK0j9kA0bT Cr2cA/Cb1A+KbWlIkMb0r+arj+HaPCw= Date: Tue, 25 May 2021 22:12:44 +0200 From: Borislav Petkov To: Yazen Ghannam Cc: "Chatradhi, Naveen Krishna" , "linux-edac@vger.kernel.org" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "mingo@redhat.com" , "mchehab@kernel.org" , "M K, Muralidhara" Subject: Re: [PATCH 1/3] x86/MCE/AMD, EDAC/mce_amd: Add new SMCA bank types. Message-ID: References: <20210511152538.148084-1-nchatrad@amd.com> <20210525200327.GA8891@aus-x-yghannam.amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210525200327.GA8891@aus-x-yghannam.amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Tue, May 25, 2021 at 04:03:27PM -0400, Yazen Ghannam wrote: > Yep, that's right. The UMCs are the only case of this so far and in the > foreseeable future. Though we may be moving towards more cases like > this. Ok, then you guys really need to make sure those strings are unique because they're in sysfs: /sys/devices/system/machinecheck/machinecheck... AFAIR, so we can't have duplicates there. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette