From: Borislav Petkov <bp@alien8.de>
To: Tony Luck <tony.luck@intel.com>
Cc: Christopher BeSerra <beserra@amazon.com>,
x86@kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] x86/mce: Provide sysfs interface to show CMCI storm state
Date: Tue, 1 Jun 2021 22:35:59 +0200 [thread overview]
Message-ID: <YLaaLws+4FEHOqQs@zn.tnic> (raw)
In-Reply-To: <20210601200505.966849-1-tony.luck@intel.com>
On Tue, Jun 01, 2021 at 01:05:05PM -0700, Tony Luck wrote:
> Scripts that process error logs can do better if they know whether
> Linux is executing in CMCI storm mode (only polling and reporting
> some errors instead of trying to report them all). While it is possible
> to parse the console log for:
>
> CMCI storm detected: switching to poll mode
> CMCI storm subsided: switching to interrupt mode
>
> messages, that is error prone.
>
> Add a new file to sysfs to report the current storm count.
>
> Reported-by: Christopher BeSerra <beserra@amazon.com>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
>
> RFC questions:
> 1) Is there a better way to do this?
Probably.
But I'm unclear as to what this whole use case is. The very first
"Scripts that process error logs" already sounds like a bad idea - I'd
expect userspace consumers to open the trace_mce_record() and get the
MCE records from there. And in that case CMCI storm shouldn't matter...
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-06-01 20:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 20:05 [RFC PATCH] x86/mce: Provide sysfs interface to show CMCI storm state Tony Luck
2021-06-01 20:35 ` Borislav Petkov [this message]
2021-06-01 20:40 ` Luck, Tony
2021-06-03 22:48 ` BeSerra, Christopher
2021-06-04 9:16 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLaaLws+4FEHOqQs@zn.tnic \
--to=bp@alien8.de \
--cc=beserra@amazon.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).