From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BF65C47094 for ; Thu, 10 Jun 2021 11:55:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0DF95613FE for ; Thu, 10 Jun 2021 11:55:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230146AbhFJL5v (ORCPT ); Thu, 10 Jun 2021 07:57:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229935AbhFJL5u (ORCPT ); Thu, 10 Jun 2021 07:57:50 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2D3CC061574; Thu, 10 Jun 2021 04:55:54 -0700 (PDT) Received: from zn.tnic (p200300ec2f0cf600e70433578266b34c.dip0.t-ipconnect.de [IPv6:2003:ec:2f0c:f600:e704:3357:8266:b34c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id B0BF01EC0493; Thu, 10 Jun 2021 13:55:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1623326152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=/OkYzBblS5E80gbut5AjIVLNBezP0yfMo4EhaUphYzk=; b=Fr1L5iVb1Zf1mpwfXQeto2+0vBXCdpABE6OxACL9kMxpiBXNWZGBcDJoS7fFN4vPyZOHV0 raJJFa1vp+t0o5K2+Y3b/d5kQ3zLz7FrEZnGw7KNTPooGxB08UvPGvNYcwP5stowzTlM+1 evUtk64+j+1mZxVwknoj5QNuJHw20lw= Date: Thu, 10 Jun 2021 13:55:46 +0200 From: Borislav Petkov To: Smita Koralahalli Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, Tony Luck , Yazen Ghannam , Muralidhara M K , Akshay Gupta , Youquan Song , Zhen Lei , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" Subject: Re: [PATCH 2/2] x86/mce: Add support for Extended Physical Address MCA changes Message-ID: References: <20210608221012.223696-1-Smita.KoralahalliChannabasappa@amd.com> <20210608221012.223696-3-Smita.KoralahalliChannabasappa@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210608221012.223696-3-Smita.KoralahalliChannabasappa@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Tue, Jun 08, 2021 at 05:10:12PM -0500, Smita Koralahalli wrote: > diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c > index f71435e53cdb..480a497877e2 100644 > --- a/arch/x86/kernel/cpu/mce/amd.c > +++ b/arch/x86/kernel/cpu/mce/amd.c > @@ -204,6 +204,12 @@ EXPORT_SYMBOL_GPL(smca_banks); > #define MAX_MCATYPE_NAME_LEN 30 > static char buf_mcatype[MAX_MCATYPE_NAME_LEN]; > > +struct smca_config { > + __u64 lsb_in_status : 1, > + __reserved_0 : 63; > +}; > +static DEFINE_PER_CPU_READ_MOSTLY(struct smca_config[MAX_NR_BANKS], smca_cfg); Per CPU and per bank, huh? For a single bit? Even if we have static DEFINE_PER_CPU_READ_MOSTLY(struct mce_bank[MAX_NR_BANKS], mce_banks_array); already? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette