From: Borislav Petkov <firstname.lastname@example.org> To: "Luck, Tony" <email@example.com> Cc: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, Mauro Carvalho Chehab <firstname.lastname@example.org>, James Morse <email@example.com>, "firstname.lastname@example.org" <email@example.com>, Robert Richter <firstname.lastname@example.org> Subject: Re: [PATCH] EDAC/mce_amd: Reduce unnecessary spew in dmesg if SMCA feature bit is not exposed Date: Tue, 15 Jun 2021 11:16:49 +0200 [thread overview] Message-ID: <YMhwAZaFr4d1QOGG@zn.tnic> (raw) In-Reply-To: <email@example.com> On Mon, Jun 14, 2021 at 10:25:36PM +0000, Luck, Tony wrote: > I expect all the Intel EDAC drivers that load based on CPU model have similar > issues. Maybe they aren't whining as loudly about not being able to find the > memory controller devices? Right. > Though perhaps this is an issue outside of EDAC and x86_match_cpu() > could do the HYPERVISOR check and return no match. The few callers > who want to believe the fictional CPU model number passed in by the > VMM would need to use some new variant of the call? Yeah, we could do X86_MATCH_VENDOR_FAM_MODEL_STEPPINGS_NOT_FEATURE notice the "NOT" and have a x86_cpu_id.not_feature which to match X86_FEATURE_HYPERVISOR. I'm not sure it is worth it, though, for a handful of drivers. The whole thing is a meh, why bother, but I got tired of this particular intent of people wanting to shut this error message up just because they should not load that driver in a VM in the first place. But what happens is they boot a guest with -cpu host and in that case that's a new CPU - family 0x19 - so it doesn't have a case 0x19 for the pr_warn_once() there. And instead of keep adding adding families there, I'd simply check X86_FEATURE_HYPERVISOR. Oh and that thing - mce_amd.c - doesn't use x86_match_cpu() so it has to be an explicit check on function entry. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-06-15 9:17 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-14 21:21 Smita Koralahalli 2021-06-14 22:01 ` Borislav Petkov 2021-06-14 22:25 ` Luck, Tony 2021-06-15 9:16 ` Borislav Petkov [this message] 2021-06-15 15:08 ` Yazen Ghannam 2021-06-15 15:18 ` Borislav Petkov 2021-06-15 16:00 ` Yazen Ghannam 2021-06-15 16:11 ` Borislav Petkov 2021-06-15 16:32 ` Yazen Ghannam 2021-06-15 16:45 ` [PATCH] EDAC/Intel: Do not load EDAC driver when running as a guest Luck, Tony 2021-06-15 17:00 ` Borislav Petkov 2021-06-15 17:44 ` [PATCH v2] " Luck, Tony 2021-06-15 17:25 ` [PATCH] EDAC/mce_amd: Reduce unnecessary spew in dmesg if SMCA feature bit is not exposed Borislav Petkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YMhwAZaFr4d1QOGG@zn.tnic \ --firstname.lastname@example.org \ --cc=Smita.KoralahalliChannabasappa@amd.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] EDAC/mce_amd: Reduce unnecessary spew in dmesg if SMCA feature bit is not exposed' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).