From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26279C48BDF for ; Tue, 15 Jun 2021 15:19:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE35261603 for ; Tue, 15 Jun 2021 15:19:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230462AbhFOPVH (ORCPT ); Tue, 15 Jun 2021 11:21:07 -0400 Received: from mail.skyhub.de ([5.9.137.197]:36798 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230452AbhFOPVG (ORCPT ); Tue, 15 Jun 2021 11:21:06 -0400 Received: from zn.tnic (p200300ec2f0f27007132ab63e0ed4371.dip0.t-ipconnect.de [IPv6:2003:ec:2f0f:2700:7132:ab63:e0ed:4371]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 5F1811EC04CC; Tue, 15 Jun 2021 17:19:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1623770340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=vuI1AvOE74lmRhMGsswqDGbG80VLscdMnetSm7TxXIc=; b=A9G/igUvX9ZJKQIFp8bIeK5wtgSLxAIsgSUAWVvhnvBMAqBVrHyYNs6bOE89p7YO0mdpkO xJeVyvlGyNMeeU2kkGStxNDufRo7GsKKZyXoG5AjC88xSq70E5c5cei8SFQdx3C4bA+mg9 roq4jyisXXnTaGq4s5TR6H5HBm1gYs0= Date: Tue, 15 Jun 2021 17:18:50 +0200 From: Borislav Petkov To: Yazen Ghannam Cc: "Luck, Tony" , Smita Koralahalli , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" , Mauro Carvalho Chehab , James Morse , Robert Richter Subject: Re: [PATCH] EDAC/mce_amd: Reduce unnecessary spew in dmesg if SMCA feature bit is not exposed Message-ID: References: <20210614212129.227698-1-Smita.KoralahalliChannabasappa@amd.com> <16a34b6834f94f139444c2ff172645e9@intel.com> <20210615150846.GA409@aus-x-yghannam.amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210615150846.GA409@aus-x-yghannam.amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Tue, Jun 15, 2021 at 11:08:46AM -0400, Yazen Ghannam wrote: > How about adding the the SMCA feature to the amd64_cpuids[] table in > amd64_edac.c? > > We can use X86_MATCH_VENDOR_FEATURE to match on AMD (and Hygon) systems > with SMCA. And we can remove the X86_MATCH_VENDOR_FAM entries for > families 17h-19h. Sure. That'll alleviate the need to add new families which support SMCA too. > I'm assuming the issue is that amd64_edac_mod is autoloading due to the > family-based device table, and this will load edac_mce_amd as a > dependency. Is it? We have early_initcall(mce_amd_init); in mce_amd.c which attempts to load this thing unconditionally. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette