From: Borislav Petkov <bp@alien8.de>
To: Jack Wang <jinpu.wang@ionos.com>
Cc: linux-edac@vger.kernel.org, yazen.ghannam@amd.com,
tony.luck@intel.com, mchehab@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EDAC/amd64: Do not load EDAC driver when running as a guest
Date: Tue, 6 Jul 2021 07:33:58 +0200 [thread overview]
Message-ID: <YOPrRh/3gZ3JETlh@zn.tnic> (raw)
In-Reply-To: <20210706050833.9852-1-jinpu.wang@ionos.com>
On Tue, Jul 06, 2021 at 07:08:33AM +0200, Jack Wang wrote:
> Similar to commit f0a029fff4a5 ("EDAC/Intel: Do not load EDAC driver when running as a guest")
>
> There's little to no point in loading an EDAC driver running in a guest.
>
> Add a check in each of the Intel EDAC drivers for X86_FEATURE_HYPERVISOR
> and simply return -ENODEV in the init routine.
Did you even read this sentence before leaving it in the commit message
or you simply copied the commit message of f0a029fff4a5 blindly?
Also:
https://lore.kernel.org/linux-edac/20210628172740.245689-1-Smita.KoralahalliChannabasappa@amd.com/
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-07-06 5:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 5:08 [PATCH] EDAC/amd64: Do not load EDAC driver when running as a guest Jack Wang
2021-07-06 5:33 ` Borislav Petkov [this message]
2021-07-06 5:38 ` Jinpu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOPrRh/3gZ3JETlh@zn.tnic \
--to=bp@alien8.de \
--cc=jinpu.wang@ionos.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=tony.luck@intel.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).