From: Borislav Petkov <bp@alien8.de>
To: Tony Luck <tony.luck@intel.com>
Cc: x86@kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org,
Sumanth Kamatala <skamatala@juniper.net>
Subject: Re: [PATCH] x86/mce/dev-mcelog: Call mce_register_decode_chain() much earlier
Date: Fri, 20 Aug 2021 14:28:45 +0200 [thread overview]
Message-ID: <YR+f/fdGIxWcLTP2@zn.tnic> (raw)
In-Reply-To: <20210819224452.1619400-1-tony.luck@intel.com>
On Thu, Aug 19, 2021 at 03:44:52PM -0700, Tony Luck wrote:
> which made sure that the logs were not lost completely by printing
> to the console. But parsing console logs is error prone. Users
> of /dev/mcelog should expect to find any early errors logged to
> standard places.
Yes, and for that matter, *all* consumers which register on the decoding
chain should get a chance to look at those records...
> Split the initialization code in dev-mcelog.c into:
> 1) an "early" part that registers for mce notifications. Call this
> directly from mcheck_init() because early_initcall() is still too late.
> This allocation is too early for kzalloc() so use memblock_alloc().
> 2) "late" part that registers the /dev/mcelog character device.
... but this looks like a hack to me: why aren't we adding those early
records to the gen_pool and kick the work to consume them *only* *after*
all consumers have been registered properly and everything is up and
running?
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-08-20 12:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 22:44 [PATCH] x86/mce/dev-mcelog: Call mce_register_decode_chain() much earlier Tony Luck
2021-08-20 12:28 ` Borislav Petkov [this message]
2021-08-20 14:43 ` Luck, Tony
2021-08-20 15:48 ` Borislav Petkov
2021-08-23 18:45 ` Luck, Tony
2021-08-23 20:41 ` [PATCH v2] x86/mce: Defer processing early errors until mcheck_late_init() Luck, Tony
2021-08-23 20:51 ` Borislav Petkov
2021-08-23 21:41 ` Luck, Tony
2021-08-24 0:31 ` [PATCH v3] x86/mce: Defer processing of early errors Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YR+f/fdGIxWcLTP2@zn.tnic \
--to=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skamatala@juniper.net \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).