From: Robert Richter <rric@kernel.org>
To: Len Baker <len.baker@gmx.com>
Cc: Borislav Petkov <bp@alien8.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Tony Luck <tony.luck@intel.com>,
James Morse <james.morse@arm.com>,
Kees Cook <keescook@chromium.org>,
linux-hardening@vger.kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] drivers/edac/edac_mc: Remove all strcpy() uses
Date: Mon, 9 Aug 2021 11:51:54 +0200 [thread overview]
Message-ID: <YRD6uoVYwCSFN0U0@rric.localdomain> (raw)
In-Reply-To: <20210807155957.10069-1-len.baker@gmx.com>
On 07.08.21 17:59:57, Len Baker wrote:
> @@ -1113,11 +1115,11 @@ void edac_mc_handle_error(const enum hw_event_mc_err_type type,
> p = e->label;
> *p = '\0';
> } else {
> - if (p != e->label) {
> - strcpy(p, OTHER_LABEL);
> - p += strlen(OTHER_LABEL);
> - }
> - strcpy(p, dimm->label);
> + const char *text = (p != e->label) ? OTHER_LABEL :
> + dimm->label;
> +
> + strscpy(p, text, len);
> + len -= strlen(p);
The logic looks broken and dimm labels are not properly copied (the
code should add an " or " separator between labels).
-Robert
> p += strlen(p);
> }
>
next prev parent reply other threads:[~2021-08-09 9:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-07 15:59 [PATCH v3] drivers/edac/edac_mc: Remove all strcpy() uses Len Baker
2021-08-07 17:09 ` Joe Perches
2021-08-08 11:26 ` Len Baker
2021-08-09 10:05 ` Robert Richter
2021-08-09 17:18 ` Joe Perches
2021-08-10 8:56 ` David Laight
2021-08-10 14:36 ` Robert Richter
2021-08-10 15:02 ` Joe Perches
2021-08-11 7:40 ` Robert Richter
2021-08-09 9:51 ` Robert Richter [this message]
2021-08-09 16:25 ` Len Baker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRD6uoVYwCSFN0U0@rric.localdomain \
--to=rric@kernel.org \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=keescook@chromium.org \
--cc=len.baker@gmx.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).