From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 217D7C433EF for ; Thu, 23 Sep 2021 14:37:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02A4061242 for ; Thu, 23 Sep 2021 14:37:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241689AbhIWOix (ORCPT ); Thu, 23 Sep 2021 10:38:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241565AbhIWOix (ORCPT ); Thu, 23 Sep 2021 10:38:53 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2136C061574; Thu, 23 Sep 2021 07:37:21 -0700 (PDT) Received: from zn.tnic (p200300ec2f0d6800d4c5e0e0616b3501.dip0.t-ipconnect.de [IPv6:2003:ec:2f0d:6800:d4c5:e0e0:616b:3501]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 309CD1EC056B; Thu, 23 Sep 2021 16:37:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1632407836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=HfoPwsxKHCcbtGaxkHIOM1bQ75QFFghWL979CqRbrFw=; b=Rx5O0nY0jYGcwQF/bSZi8maFoS15Mo0LtUhi5e0YG9Q+Yq8Ck3sI3RsyTcaBFSB3oH0EmV Yld3Ju3Dx5hg8HjdqY8dj0ZSLpHYHfhhZLc+WCOKEOhwNOGpMwoQ699jFogBTuB3ZCer5w /QVZE3GiP4L7x3fZ39Cl8wHquNRAnf0= Date: Thu, 23 Sep 2021 16:37:10 +0200 From: Borislav Petkov To: Yazen Ghannam Cc: Mukul Joshi , linux-edac@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, mchehab@kernel.org, amd-gfx@lists.freedesktop.org Subject: Re: [PATCHv3 2/2] drm/amdgpu: Register MCE notifier for Aldebaran RAS Message-ID: References: <20210913021311.12896-2-mukul.joshi@amd.com> <20210922193620.15925-1-mukul.joshi@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Thu, Sep 23, 2021 at 02:29:07PM +0000, Yazen Ghannam wrote: > > + /* > > + * If the error was generated in UMC_V2, which belongs to GPU UMCs, > > + * and error occurred in DramECC (Extended error code = 0) then only > > + * process the error, else bail out. > > + */ > > + if (!m || !((smca_get_bank_type(m->bank) == SMCA_UMC_V2) && > > + (XEC(m->status, 0x1f) == 0x0))) > > The MCA_STATUS[ErrorCodeExt] field is bits [21:16], so the mask should be > 0x3f. > > > + return NOTIFY_DONE; > > + > > + /* > > + * If it is correctable error, return. > > + */ > > + if (mce_is_correctable(m)) > > + return NOTIFY_OK; > > Shouldn't this be "NOTIFY_DONE" if "don't care" about this error? I think the logic here is to stop calling any further consumers on the notify chain because this is a GPU correctable error and they can't do anything about it anyway, right? Or am I misreading it? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette