From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 669DEC433EF for ; Thu, 11 Nov 2021 18:06:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 38E696112F for ; Thu, 11 Nov 2021 18:06:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232203AbhKKSIx (ORCPT ); Thu, 11 Nov 2021 13:08:53 -0500 Received: from mail.skyhub.de ([5.9.137.197]:41344 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229710AbhKKSIx (ORCPT ); Thu, 11 Nov 2021 13:08:53 -0500 Received: from zn.tnic (p200300ec2f0fc200f9f6db8f5ba53f04.dip0.t-ipconnect.de [IPv6:2003:ec:2f0f:c200:f9f6:db8f:5ba5:3f04]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 86FD91EC0516; Thu, 11 Nov 2021 19:06:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1636653962; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=JCc2yGR9ihcbHjSsyV2YI+8pjgQv2iAiqwBQ6/ZyWnw=; b=LunZFIpysoc0ShrDIyhOLYIlI8VWxczDxpvVSUyvXkCK+10ug+eH4F12t88ptXQmyQjh9J pAzb/kZwekyJ7yqbZHPRuV/zsSpgTufETMpYNrXlqLczY0r6zY8EcHNtCZ/5GUgAf2qyJW nz7B6c6cTuzbB/hqaUSf3uAy7Nx3890= Date: Thu, 11 Nov 2021 19:05:55 +0100 From: Borislav Petkov To: "Chatradhi, Naveen Krishna" Cc: linux-edac@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, mchehab@kernel.org, yazen.ghannam@amd.com, Muralidhara M K Subject: Re: [PATCH v6 3/5] EDAC/amd64: Extend family ops functions Message-ID: References: <20211028130106.15701-1-nchatrad@amd.com> <20211028130106.15701-4-nchatrad@amd.com> <0006a641-44e7-5cf0-04e2-8c4499765b77@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <0006a641-44e7-5cf0-04e2-8c4499765b77@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Thu, Nov 11, 2021 at 09:53:32PM +0530, Chatradhi, Naveen Krishna wrote: > Agreed, will create family_XXh_init() under per_family_init()'s switch. No, you need to simply assign the per-family stuff in that one big switch-case - no additional family_XXh_init() functions. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette