From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 240D9C433F5 for ; Fri, 30 Sep 2022 14:42:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231192AbiI3Omq (ORCPT ); Fri, 30 Sep 2022 10:42:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229646AbiI3Omp (ORCPT ); Fri, 30 Sep 2022 10:42:45 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFFA7106F62; Fri, 30 Sep 2022 07:42:43 -0700 (PDT) Received: from zn.tnic (p200300ea9733e70a329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e70a:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 7C9891EC0628; Fri, 30 Sep 2022 16:42:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1664548955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=lE8hUaSKMIxph78uNTz4/bEjUx1Lg6ndbZxkvbEdB1g=; b=UX0YK1JxZ8WsRZl893GKz7hKbtsNZZcBa9rKfaJNgyItsYvowPwm/k0nPHkSk5wzWBgGbm qfWZruijjpI+q6kk2BmGYETw5GZLxFUIw3+RMyd79go8+zYv1FoujRe+bejsRhzRVEIJKf wyql6YGSPx2tcMp8MTFlvS3JALEq3Z0= Date: Fri, 30 Sep 2022 16:42:31 +0200 From: Borislav Petkov To: Serge Semin Cc: Michal Simek , Mauro Carvalho Chehab , Tony Luck , James Morse , Robert Richter , Serge Semin , Alexey Malahov , Michail Ivanov , Pavel Parkhomenko , Punnaiah Choudary Kalluri , Manish Narani , Dinh Nguyen , Rob Herring , Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND v3 14/17] EDAC/synopsys: Detach Zynq DDRC controller support Message-ID: References: <20220929232712.12202-1-Sergey.Semin@baikalelectronics.ru> <20220929232712.12202-15-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220929232712.12202-15-Sergey.Semin@baikalelectronics.ru> Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Fri, Sep 30, 2022 at 02:27:09AM +0300, Serge Semin wrote: > It was a bad idea in the first place to combine two absolutely different > controllers support in a single driver [1]. It caused having an additional > level of abstraction, which obviously have needlessly overcomplicated the > driver and as such caused many problems in the new main controller > features support implementation. The solution looks even more unreasonable > now seeing the justification of having both controllers support in a > single driver hasn't been implemented by the original code author [2]. Yeah, no, you need to give more concrete details here. Why exactly is this a problem? Are you saying that if synopsys puts out 10 incompatible memory controllers, we should have 10 separate EDAC drivers? Hell no. synopsys_edac.c is not a huge file and the probe logic which matches which synps_platform_data to load is pretty straight-forward to me. But maybe I'm missing something so please explain in detail what the actual problems with this are? Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette