Linux-EDAC Archive on lore.kernel.org
 help / color / Atom feed
From: "Shenhar, Talel" <talel@amazon.com>
To: Rob Herring <robh@kernel.org>
Cc: <robh+dt@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
	<mchehab@kernel.org>, <davem@davemloft.net>,
	<catalin.marinas@arm.com>, <devicetree@vger.kernel.org>,
	<ronenk@amazon.com>, <james.morse@arm.com>, <bp@alien8.de>,
	<linux-kernel@vger.kernel.org>, <linux-edac@vger.kernel.org>,
	<hhhawa@amazon.com>, <hanochu@amazon.com>, <mark.rutland@arm.com>,
	<eitan@amazon.com>, <will@kernel.org>,
	<nicolas.ferre@microchip.com>, <jonnyc@amazon.com>,
	<gregkh@linuxfoundation.org>
Subject: Re: [PATCH v8 1/2] dt-bindings: edac: al-mc-edac: Amazon's Annapurna Labs Memory Controller EDAC
Date: Tue, 28 Jul 2020 11:52:08 +0300
Message-ID: <a07d6f7e-eae7-aa14-972c-72e69460b1e9@amazon.com> (raw)
In-Reply-To: <20200727181424.GA639053@bogus>


On 7/27/2020 9:14 PM, Rob Herring wrote:
> On Sun, 26 Jul 2020 22:15:54 +0300, Talel Shenhar wrote:
>> Document Amazon's Annapurna Labs Memory Controller EDAC SoC binding.
>>
>> Signed-off-by: Talel Shenhar <talel@amazon.com>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> ---
>>   .../bindings/edac/amazon,al-mc-edac.yaml      | 52 +++++++++++++++++++
>>   1 file changed, 52 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/edac/amazon,al-mc-edac.yaml
>>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/edac/amazon,al-mc-edac.example.dt.yaml: example-0: edac@f0080000:reg:0: [0, 4027056128, 0, 65536] is too long
>
>
> See https://patchwork.ozlabs.org/patch/1336532
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure dt-schema is up to date:
>
> pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
>
> Please check and re-submit.

Thanks Rob,

Indeed I am not able to see this error.

Even tried updating dt-schema.

Even targeted check didn't give anything:

linux-ras$ make dt_binding_check 
DT_SCHEMA_FILES=Documentation/devicetree/bindings/edac/amazon,al-mc-edac.yaml
   CHKDT Documentation/devicetree/bindings/edac/amazon,al-mc-edac.yaml
   DTC 
Documentation/devicetree/bindings/edac/amazon,al-mc-edac.example.dt.yaml
   CHECK 
Documentation/devicetree/bindings/edac/amazon,al-mc-edac.example.dt.yaml

ill look into it and publish v9.

>

  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-26 19:15 [PATCH v8 0/2] " Talel Shenhar
2020-07-26 19:15 ` [PATCH v8 1/2] dt-bindings: edac: al-mc-edac: " Talel Shenhar
2020-07-27 18:14   ` Rob Herring
2020-07-28  8:52     ` Shenhar, Talel [this message]
2020-07-26 19:15 ` [PATCH v8 2/2] EDAC: al-mc-edac: Introduce " Talel Shenhar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a07d6f7e-eae7-aa14-972c-72e69460b1e9@amazon.com \
    --to=talel@amazon.com \
    --cc=bp@alien8.de \
    --cc=catalin.marinas@arm.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=eitan@amazon.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hanochu@amazon.com \
    --cc=hhhawa@amazon.com \
    --cc=james.morse@arm.com \
    --cc=jonnyc@amazon.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=ronenk@amazon.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-EDAC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-edac/0 linux-edac/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-edac linux-edac/ https://lore.kernel.org/linux-edac \
		linux-edac@vger.kernel.org
	public-inbox-index linux-edac

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-edac


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git