Linux-EDAC Archive on lore.kernel.org
 help / color / Atom feed
From: Shiping Ji <shiping.linux@gmail.com>
To: Borislav Petkov <bp@alien8.de>
Cc: James Morse <james.morse@arm.com>,
	robh+dt@kernel.org, mark.rutland@arm.com,
	devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	linux-edac@vger.kernel.org,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	sashal@kernel.org, hangl@microsoft.com,
	Lei Wang <lewan@microsoft.com>,
	ruizhao@microsoft.com, shji@microsoft.com,
	Scott Branden <scott.branden@broadcom.com>,
	Yuqing Shen <yuqing.shen@broadcom.com>,
	ray.jui@broadcom.com, wangglei@gmail.com
Subject: Re: [PATCH v9 1/2] dt-bindings: edac: arm-dmc520.txt
Date: Thu, 16 Jan 2020 16:05:48 -0800
Message-ID: <adeadf1f-df85-8af1-ccbd-fc8ff2cb4d43@gmail.com> (raw)
In-Reply-To: <20200116233939.GI27148@zn.tnic>

On 1/16/2020 3:39 PM, Borislav Petkov wrote:
> On Wed, Jan 15, 2020 at 06:32:27AM -0800, Shiping Ji wrote:
>> This is the device tree bindings for new EDAC driver dmc520_edac.c.
>>
>> Signed-off-by: Shiping Ji <shiping.linux@gmail.com>
>> Signed-off-by: Lei Wang <leiwang_git@outlook.com>
>> Reviewed-by: James Morse <james.morse@arm.com>
> 
> So for this patch, v2 had Rui Zhao as an author:
> 
> https://lkml.kernel.org/r/BN7PR08MB5572B3388B2D7DC8F6C7F285AE4C0@BN7PR08MB5572.namprd08.prod.outlook.com
> 
> v3 got Lei as an author:
> 
> https://lkml.kernel.org/r/CY1PR0401MB1244062C1738B09D6100F202860A0@CY1PR0401MB1244.namprd04.prod.outlook.com
> 
> and now it is you.
> 
> So when you send next time, think about who's going to be the author.

I'll make sure Lei is the author (From:) in the next patches.

>> +     line numbers. The valid interrupt names are the followings:
> 
> WARNING: 'followings' may be misspelled - perhaps 'following'?
> #51: FILE: Documentation/devicetree/bindings/edac/arm-dmc520.txt:10:
> +     line numbers. The valid interrupt names are the followings:

Yes, I think this can be fixed. I checked the scripts/spelling.txt and it does suggest using 'following' instead.
 
> Please integrate scripts/checkpatch.pl into your patch creation
> workflow. Some of the warnings/errors *actually* make sense.

Yes, we will.

> Also, this patch throws this other checkpatch warning:
> 
> WARNING: DT bindings should be in DT schema format. See: Documentation/devicetree/writing-schema.rst
> 
> but since Rob reviewed it, I'm going to assume checkpatch is wrong here.
> 
> Thx.
 
The check seems to warn the next file in .txt format which should be rather in the new .yaml format. We'll try to make one next.

Thanks!

-- 
Best regards,
Shiping Ji

  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-15 14:32 Shiping Ji
2020-01-15 20:16 ` Rob Herring
2020-01-16 23:39 ` Borislav Petkov
2020-01-17  0:05   ` Shiping Ji [this message]
2020-01-21 17:53   ` Rob Herring
2020-01-21 17:56     ` Shiping Ji

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adeadf1f-df85-8af1-ccbd-fc8ff2cb4d43@gmail.com \
    --to=shiping.linux@gmail.com \
    --cc=bp@alien8.de \
    --cc=devicetree@vger.kernel.org \
    --cc=hangl@microsoft.com \
    --cc=james.morse@arm.com \
    --cc=lewan@microsoft.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@kernel.org \
    --cc=ray.jui@broadcom.com \
    --cc=robh+dt@kernel.org \
    --cc=ruizhao@microsoft.com \
    --cc=sashal@kernel.org \
    --cc=scott.branden@broadcom.com \
    --cc=shji@microsoft.com \
    --cc=wangglei@gmail.com \
    --cc=yuqing.shen@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-EDAC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-edac/0 linux-edac/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-edac linux-edac/ https://lore.kernel.org/linux-edac \
		linux-edac@vger.kernel.org
	public-inbox-index linux-edac

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-edac


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git