Linux-EDAC Archive on lore.kernel.org
 help / color / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Borislav Petkov <bp@alien8.de>
Cc: Meelis Roos <mroos@linux.ee>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	x86@kernel.org, linux-edac@vger.kernel.org,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: 4.15-rc6 PTI regression: L1 TLB mismatch MCE on Athlon64
Date: Wed, 3 Jan 2018 14:17:00 +0100 (CET)
Message-ID: <alpine.DEB.2.20.1801031407180.1957@nanos> (raw)

On Wed, 3 Jan 2018, Borislav Petkov wrote:
> On Wed, Jan 03, 2018 at 11:16:48AM +0200, Meelis Roos wrote:
> > ---[ ESPfix Area ]---
> > 0xffffff0000000000-0xffffff1800000000          96G                               pud
> > 0xffffff1800000000-0xffffff1800009000          36K                               pte
> > 0xffffff1800009000-0xffffff180000a000           4K     ro                     NX pte
> > 0xffffff180000a000-0xffffff1800019000          60K                               pte
> > 0xffffff1800019000-0xffffff180001a000           4K     ro                     NX pte
> > 0xffffff180001a000-0xffffff1800029000          60K                               pte
> > 0xffffff1800029000-0xffffff180002a000           4K     ro                     NX pte
> > 0xffffff180002a000-0xffffff1800039000          60K                               pte
> > 0xffffff1800039000-0xffffff180003a000           4K     ro                     NX pte
> > 0xffffff180003a000-0xffffff1800049000          60K                               pte
> > 0xffffff1800049000-0xffffff180004a000           4K     ro                     NX pte
> > 0xffffff180004a000-0xffffff1800059000          60K                               pte
> > 0xffffff1800059000-0xffffff180005a000           4K     ro                     NX pte
> > 0xffffff180005a000-0xffffff1800069000          60K                               pte
> > 0xffffff1800069000-0xffffff180006a000           4K     ro                     NX pte
> > 0xffffff180006a000-0xffffff1800079000          60K                               pte
> > ... 131059 entries skipped ... 
> > ---[ High Kernel Mapping ]---
> > 0xffffffff80000000-0xffffffff81e00000          30M                               pmd
> > 0xffffffff81e00000-0xffffffff82000000           2M     ro         PSE     GLB x  pmd
> 
> Ha, this must be it. What I said yesterday about the guard hole
> hypervisor range was wrong because we're looking at VA slice [47:12] and
> this one matches:

That's the entry area, which is mapped into kernel _AND_ user space. Now
that's special because we switch CR3 while we are executing there.

And this one is:

0xffffffff81e00000-0xffffffff82000000           2M     ro         PSE     GLB x  pmd

and the one we switch to is:

0xffffffff81000000-0xffffffff82000000          16M     ro         PSE         x  pmd

Meelis, does the patch below fix it for you?

Thanks,

	tglx

8<-------------------
---
To unsubscribe from this list: send the line "unsubscribe linux-edac" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--- a/arch/x86/mm/pti.c
+++ b/arch/x86/mm/pti.c
@@ -367,7 +367,8 @@ static void __init pti_setup_espfix64(vo
 static void __init pti_clone_entry_text(void)
 {
 	pti_clone_pmds((unsigned long) __entry_text_start,
-			(unsigned long) __irqentry_text_end, _PAGE_RW);
+			(unsigned long) __irqentry_text_end,
+		       _PAGE_RW | _PAGE_GLOBAL);
 }
 
 /*

             reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-03 13:17 Thomas Gleixner [this message]
2018-01-03 14:01 mroos

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1801031407180.1957@nanos \
    --to=tglx@linutronix.de \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mroos@linux.ee \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-EDAC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-edac/0 linux-edac/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-edac linux-edac/ https://lore.kernel.org/linux-edac \
		linux-edac@vger.kernel.org
	public-inbox-index linux-edac

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-edac


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git