Linux-EDAC Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH RESEND] MAINTAINERS: rectify EDAC-SIFIVE entry
@ 2020-04-13  7:34 Lukas Bulwahn
  2020-04-13  8:15 ` Borislav Petkov
  0 siblings, 1 reply; 3+ messages in thread
From: Lukas Bulwahn @ 2020-04-13  7:34 UTC (permalink / raw)
  To: Paul Walmsley
  Cc: Christoph Hellwig, Borislav Petkov, Yash Shah, linux-edac,
	Sebastian Duda, Joe Perches, kernel-janitors, linux-kernel,
	Lukas Bulwahn

Commit 9209fb51896f ("riscv: move sifive_l2_cache.c to drivers/soc") moved
arch/riscv/mm/sifive_l2_cache.c to drivers/soc/sifive/sifive_l2_cache.c
and adjusted the MAINTAINERS EDAC-SIFIVE entry but slipped in a mistake.

Since then, ./scripts/get_maintainer.pl --self-test complains:

  warning: no file matches F: drivers/soc/sifive_l2_cache.c

Rectify the EDAC-SIFIVE entry in MAINTAINERS now.

Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Paul, please pick this patch.

v1: https://lore.kernel.org/lkml/20200304144045.15060-1-lukas.bulwahn@gmail.com/
  - was not picked up.

v1-resend: applies on v5.7-rc1

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index e64e5db31497..e28676766b26 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6172,7 +6172,7 @@ M:	Yash Shah <yash.shah@sifive.com>
 L:	linux-edac@vger.kernel.org
 S:	Supported
 F:	drivers/edac/sifive_edac.c
-F:	drivers/soc/sifive_l2_cache.c
+F:	drivers/soc/sifive/sifive_l2_cache.c
 
 EDAC-SKYLAKE
 M:	Tony Luck <tony.luck@intel.com>
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH RESEND] MAINTAINERS: rectify EDAC-SIFIVE entry
  2020-04-13  7:34 [PATCH RESEND] MAINTAINERS: rectify EDAC-SIFIVE entry Lukas Bulwahn
@ 2020-04-13  8:15 ` Borislav Petkov
  2020-04-13 12:00   ` Lukas Bulwahn
  0 siblings, 1 reply; 3+ messages in thread
From: Borislav Petkov @ 2020-04-13  8:15 UTC (permalink / raw)
  To: Lukas Bulwahn
  Cc: Paul Walmsley, Christoph Hellwig, Yash Shah, linux-edac,
	Sebastian Duda, Joe Perches, kernel-janitors, linux-kernel

On Mon, Apr 13, 2020 at 09:34:47AM +0200, Lukas Bulwahn wrote:
> Commit 9209fb51896f ("riscv: move sifive_l2_cache.c to drivers/soc") moved
> arch/riscv/mm/sifive_l2_cache.c to drivers/soc/sifive/sifive_l2_cache.c
> and adjusted the MAINTAINERS EDAC-SIFIVE entry but slipped in a mistake.
> 
> Since then, ./scripts/get_maintainer.pl --self-test complains:
> 
>   warning: no file matches F: drivers/soc/sifive_l2_cache.c
> 
> Rectify the EDAC-SIFIVE entry in MAINTAINERS now.
> 
> Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
> Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> Paul, please pick this patch.
> 
> v1: https://lore.kernel.org/lkml/20200304144045.15060-1-lukas.bulwahn@gmail.com/
>   - was not picked up.
> 
> v1-resend: applies on v5.7-rc1
> 
>  MAINTAINERS | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e64e5db31497..e28676766b26 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6172,7 +6172,7 @@ M:	Yash Shah <yash.shah@sifive.com>
>  L:	linux-edac@vger.kernel.org
>  S:	Supported
>  F:	drivers/edac/sifive_edac.c
> -F:	drivers/soc/sifive_l2_cache.c
> +F:	drivers/soc/sifive/sifive_l2_cache.c

Looking at that a bit - I think the right thing to do is to remove that
sifive_l2_cache.c file from the EDAC-SIFIVE file pattern because the
edac driver is simply using the L2 thing to register on its notifier
chain, i.e., using an external facility, like all the drivers do. And the
l2_cache thing is not part of the edac driver.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH RESEND] MAINTAINERS: rectify EDAC-SIFIVE entry
  2020-04-13  8:15 ` Borislav Petkov
@ 2020-04-13 12:00   ` Lukas Bulwahn
  0 siblings, 0 replies; 3+ messages in thread
From: Lukas Bulwahn @ 2020-04-13 12:00 UTC (permalink / raw)
  To: Borislav Petkov
  Cc: Lukas Bulwahn, Paul Walmsley, Christoph Hellwig, Yash Shah,
	linux-edac, Sebastian Duda, Joe Perches, kernel-janitors,
	linux-kernel



On Mon, 13 Apr 2020, Borislav Petkov wrote:
> 
> Looking at that a bit - I think the right thing to do is to remove that
> sifive_l2_cache.c file from the EDAC-SIFIVE file pattern because the
> edac driver is simply using the L2 thing to register on its notifier
> chain, i.e., using an external facility, like all the drivers do. And the
> l2_cache thing is not part of the edac driver.
> 

Thanks for the pointer.

I adjusted the patch, first accidently sent a broken PATCH v2 (which 
shall be ignored), but this PATCH v3 shall be picked:

https://lore.kernel.org/lkml/20200413115255.7100-1-lukas.bulwahn@gmail.com/


Lukas

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-13  7:34 [PATCH RESEND] MAINTAINERS: rectify EDAC-SIFIVE entry Lukas Bulwahn
2020-04-13  8:15 ` Borislav Petkov
2020-04-13 12:00   ` Lukas Bulwahn

Linux-EDAC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-edac/0 linux-edac/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-edac linux-edac/ https://lore.kernel.org/linux-edac \
		linux-edac@vger.kernel.org
	public-inbox-index linux-edac

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-edac


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git