* [PATCH v2] MAINTAINERS: place sifive_l2_cache.c only in SIFIVE DRIVERS
@ 2020-04-13 11:47 Lukas Bulwahn
2020-04-13 12:02 ` Lukas Bulwahn
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Bulwahn @ 2020-04-13 11:47 UTC (permalink / raw)
To: Paul Walmsley
Cc: Christoph Hellwig, Borislav Petkov, Yash Shah, linux-edac,
Sebastian Duda, Joe Perches, kernel-janitors, linux-kernel,
Lukas Bulwahn
Commit 9209fb51896f ("riscv: move sifive_l2_cache.c to drivers/soc") moved
arch/riscv/mm/sifive_l2_cache.c to drivers/soc/sifive/sifive_l2_cache.c
and adjusted the MAINTAINERS EDAC-SIFIVE entry but slipped in a mistake.
Since then, ./scripts/get_maintainer.pl --self-test complains:
warning: no file matches F: drivers/soc/sifive_l2_cache.c
Boris suggested that sifive_l2_cache.c is considered part of the SIFIVE
DRIVERS, not part of EDAC-SIFIVE. So, we can simply drop this entry, and
by the sifive keyword pattern in SIFIVE PATTERNS, it is automatically part
of the SIFIVE DRIVERS.
Suggested-by: Borislav Petkov <bp@alien8.de>
Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Paul, please pick this patch.
v1: https://lore.kernel.org/lkml/20200304144045.15060-1-lukas.bulwahn@gmail.com/
- was not picked up.
v1-resend: https://lore.kernel.org/lkml/20200413073447.9284-1-lukas.bulwahn@gmail.com/
v2: reworked based on Boris comment; applies on v5.7-rc1
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index e64e5db31497..e28676766b26 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6172,7 +6172,7 @@ M: Yash Shah <yash.shah@sifive.com>
L: linux-edac@vger.kernel.org
S: Supported
F: drivers/edac/sifive_edac.c
-F: drivers/soc/sifive_l2_cache.c
+F: drivers/soc/sifive/sifive_l2_cache.c
EDAC-SKYLAKE
M: Tony Luck <tony.luck@intel.com>
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] MAINTAINERS: place sifive_l2_cache.c only in SIFIVE DRIVERS
2020-04-13 11:47 [PATCH v2] MAINTAINERS: place sifive_l2_cache.c only in SIFIVE DRIVERS Lukas Bulwahn
@ 2020-04-13 12:02 ` Lukas Bulwahn
0 siblings, 0 replies; 2+ messages in thread
From: Lukas Bulwahn @ 2020-04-13 12:02 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: Paul Walmsley, Christoph Hellwig, Borislav Petkov, Yash Shah,
linux-edac, Sebastian Duda, Joe Perches, kernel-janitors,
linux-kernel
On Mon, 13 Apr 2020, Lukas Bulwahn wrote:
> Commit 9209fb51896f ("riscv: move sifive_l2_cache.c to drivers/soc") moved
> arch/riscv/mm/sifive_l2_cache.c to drivers/soc/sifive/sifive_l2_cache.c
> and adjusted the MAINTAINERS EDAC-SIFIVE entry but slipped in a mistake.
>
> Since then, ./scripts/get_maintainer.pl --self-test complains:
>
> warning: no file matches F: drivers/soc/sifive_l2_cache.c
>
> Boris suggested that sifive_l2_cache.c is considered part of the SIFIVE
> DRIVERS, not part of EDAC-SIFIVE. So, we can simply drop this entry, and
> by the sifive keyword pattern in SIFIVE PATTERNS, it is automatically part
> of the SIFIVE DRIVERS.
>
> Suggested-by: Borislav Petkov <bp@alien8.de>
> Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
> Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> Paul, please pick this patch.
>
> v1: https://lore.kernel.org/lkml/20200304144045.15060-1-lukas.bulwahn@gmail.com/
> - was not picked up.
>
> v1-resend: https://lore.kernel.org/lkml/20200413073447.9284-1-lukas.bulwahn@gmail.com/
>
> v2: reworked based on Boris comment; applies on v5.7-rc1
>
>
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e64e5db31497..e28676766b26 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6172,7 +6172,7 @@ M: Yash Shah <yash.shah@sifive.com>
> L: linux-edac@vger.kernel.org
> S: Supported
> F: drivers/edac/sifive_edac.c
> -F: drivers/soc/sifive_l2_cache.c
> +F: drivers/soc/sifive/sifive_l2_cache.c
>
> EDAC-SKYLAKE
> M: Tony Luck <tony.luck@intel.com>
> --
> 2.17.1
>
>
Please ignore this patch. I accidently sent this patch out too quickly.
Please consider and pick this PATCH v3 instead:
https://lore.kernel.org/lkml/20200413115255.7100-1-lukas.bulwahn@gmail.com/
Lukas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-13 12:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-13 11:47 [PATCH v2] MAINTAINERS: place sifive_l2_cache.c only in SIFIVE DRIVERS Lukas Bulwahn
2020-04-13 12:02 ` Lukas Bulwahn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).