linux-edac.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Monakov <amonakov@ispras.ru>
To: Jacky Hu <hengqing.hu@gmail.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
	linux-hwmon@vger.kernel.org, linux-edac@vger.kernel.org,
	linux-kernel@vger.kernel.org, tony.luck@intel.com,
	x86@kernel.org, yazen.ghannam@amd.com, bp@alien8.de,
	clemens@ladisch.de
Subject: Re: [PATCH] hwmon: (k10temp) Add AMD family 17h model 60h probe
Date: Wed, 17 Jun 2020 17:54:36 +0300 (MSK)	[thread overview]
Message-ID: <alpine.LNX.2.20.13.2006171739010.31660@monopod.intra.ispras.ru> (raw)
In-Reply-To: <20200617071927.GA398128@i716>

Hi,

I've already said in my patch submission (which was Cc'ed to LKML,
linux-edac and linux-hwmon so you should have been able to find it):

>> It appears SMU offsets for reading current/voltage and CCD temperature
>> have changed for this generation (reads from currently used offsets
>> yield zeros), so those features cannot be enabled so trivially.

In https://github.com/FlyGoat/ryzen_nb_smu/issues/3 there some
reverse-engineered info that indicates that for Renoir, SMU region has been
moved to 0x6F000. Its layout also changed, as far as I can tell.

(also, please ask yourself if you want to offer the maintainers an apology)

Alexander

  parent reply	other threads:[~2020-06-17 15:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-07  4:37 [PATCH 0/2] MCA and EDAC updates for AMD Family 17h, Model 60h Jacky Hu
2020-06-07  4:37 ` [PATCH 1/2] x86/amd_nb: Add Family 17h, Model 60h PCI IDs Jacky Hu
2020-06-16 18:08   ` Borislav Petkov
2020-06-07  4:37 ` [PATCH 2/2] EDAC/amd64: Add family ops for Family 17h Models 60h-6Fh Jacky Hu
2020-06-16 18:09   ` Borislav Petkov
2020-06-17  1:32     ` [PATCH] hwmon: (k10temp) Add AMD family 17h model 60h probe Jacky Hu
2020-06-17  3:40       ` Guenter Roeck
2020-06-17  7:19         ` Jacky Hu
2020-06-17 14:33           ` Guenter Roeck
2020-06-17 14:55             ` Jacky Hu
2020-06-17 14:54           ` Alexander Monakov [this message]
2020-06-17 15:07             ` Jacky Hu
2020-06-17 15:22               ` Borislav Petkov
2020-06-15 11:59 ` [PATCH 0/2] MCA and EDAC updates for AMD Family 17h, Model 60h Borislav Petkov
2020-06-15 15:01   ` Guenter Roeck
2020-06-16 14:35     ` Borislav Petkov
2020-06-16 14:46       ` Guenter Roeck
2020-06-16 14:55         ` Borislav Petkov
2020-06-16 14:11   ` Yazen Ghannam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.20.13.2006171739010.31660@monopod.intra.ispras.ru \
    --to=amonakov@ispras.ru \
    --cc=bp@alien8.de \
    --cc=clemens@ladisch.de \
    --cc=hengqing.hu@gmail.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=yazen.ghannam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).