From: Markus Elfring <Markus.Elfring@web.de>
To: Borislav Petkov <bp@alien8.de>, linux-edac@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Doug Thompson <dougthompson@xmission.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
James Morse <james.morse@arm.com>, Kangjie Lu <kjlu@umn.edu>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Qiushi Wu <wu000273@umn.edu>,
Robert Richter <rrichter@marvell.com>,
Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH] edac: Fix reference count leak in edac_device_register_sysfs_main_kobj()
Date: Fri, 29 May 2020 11:40:47 +0200 [thread overview]
Message-ID: <c304a0b0-692a-0696-6750-05a3db6a4b42@web.de> (raw)
In-Reply-To: <20200529093644.GC9011@zn.tnic>
>> * The label “err_out” can be replaced by direct return statement,
>> can't it?
>
> No, it cannot. It keeps the error handling code out-of-line so that the
> function body remains readable.
Have we got different programming expectations also around the application
of the Linux coding style?
Regards,
Markus
next prev parent reply other threads:[~2020-05-29 9:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 9:20 [PATCH] edac: Fix reference count leak in edac_device_register_sysfs_main_kobj() Markus Elfring
2020-05-29 9:36 ` Borislav Petkov
2020-05-29 9:40 ` Markus Elfring [this message]
2020-05-29 9:47 ` Borislav Petkov
2020-05-29 10:40 ` Markus Elfring
2020-05-29 11:50 ` Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2020-05-29 8:45 [PATCH] " Markus Elfring
2020-05-29 9:08 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c304a0b0-692a-0696-6750-05a3db6a4b42@web.de \
--to=markus.elfring@web.de \
--cc=bp@alien8.de \
--cc=dougthompson@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=james.morse@arm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rrichter@marvell.com \
--cc=tony.luck@intel.com \
--cc=wu000273@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).