From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D9D5C28CC5 for ; Wed, 5 Jun 2019 15:13:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5261B206C3 for ; Wed, 5 Jun 2019 15:13:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728220AbfFEPNJ (ORCPT ); Wed, 5 Jun 2019 11:13:09 -0400 Received: from foss.arm.com ([217.140.101.70]:33182 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727971AbfFEPNJ (ORCPT ); Wed, 5 Jun 2019 11:13:09 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 76A5A374; Wed, 5 Jun 2019 08:13:08 -0700 (PDT) Received: from [10.1.196.105] (eglon.cambridge.arm.com [10.1.196.105]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8A19E3F246; Wed, 5 Jun 2019 08:13:05 -0700 (PDT) Subject: Re: [PATCH 2/2] edac: add support for Amazon's Annapurna Labs EDAC To: Borislav Petkov , "Herrenschmidt, Benjamin" Cc: "robh+dt@kernel.org" , "Woodhouse, David" , "paulmck@linux.ibm.com" , "mchehab@kernel.org" , "mark.rutland@arm.com" , "Hawa, Hanna" , "gregkh@linuxfoundation.org" , "davem@davemloft.net" , "nicolas.ferre@microchip.com" , "devicetree@vger.kernel.org" , "Shenhar, Talel" , "linux-kernel@vger.kernel.org" , "Chocron, Jonathan" , "Krupnik, Ronen" , "linux-edac@vger.kernel.org" , "Hanoch, Uri" References: <1559211329-13098-1-git-send-email-hhhawa@amazon.com> <1559211329-13098-3-git-send-email-hhhawa@amazon.com> <20190531051400.GA2275@cz.tnic> From: James Morse Message-ID: Date: Wed, 5 Jun 2019 16:13:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190531051400.GA2275@cz.tnic> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org Hi guys, On 31/05/2019 06:14, Borislav Petkov wrote: > On Fri, May 31, 2019 at 01:15:33AM +0000, Herrenschmidt, Benjamin wrote: >> This isn't terribly helpful, there's nothing telling anybody which of >> those files corresponds to an ARM SoC :-) > > drivers/edac/altera_edac.c is one example. > > Also, James and I have a small writeup on how an arm driver should look > like, we just need to polish it up and post it. > > James? Yes I should get on with that. Its mostly for platforms which end up with multiple piecemeal drivers and some co-ordination is needed. It doesn't look like that will be a problem here. >> That said ... >> >> You really want a single EDAC driver that contains all the stuff for >> the caches, the memory controller, etc... ? This has to be platform specific as it has integration-time dependencies and firmware dependencies. Doing it as a platform driver matched from the machine-compatible may be more straightforward today. The DT will already say "compatible = arm,cortex-a57" for the Alpine-v2, what that 'edac_l1_l2' node is telling us is the integration/firmware stuff has been done, and the imp-def instructions can be used. Thanks, James