From: Joe Perches <joe@perches.com>
To: Amy.Shih@advantech.com.tw, she90122@gmail.com
Cc: Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
James Morse <james.morse@arm.com>,
Robert Richter <rrichter@marvell.com>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
oakley.ding@advantech.com.tw
Subject: Re: [v1,1/1] EDAC: (pnd2) Fix the log level for message "Failed to register device with error %d"
Date: Thu, 19 Mar 2020 18:54:34 -0700 [thread overview]
Message-ID: <e67eefc91d4f54a5fbf64be9e6bee94680461b60.camel@perches.com> (raw)
In-Reply-To: <20200317062828.18807-1-Amy.Shih@advantech.com.tw>
On Tue, 2020-03-17 at 06:28 +0000, Amy.Shih@advantech.com.tw wrote:
> From: Amy Shih <amy.shih@advantech.com.tw>
>
> Fix the log level from "KERN_ERR" to "KERN_INFO" for message "Failed to
> register device with error %d", since it is not the error message but
> the information to notice the user.
[]
> diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c
[]
> @@ -1572,7 +1572,8 @@ static int __init pnd2_init(void)
>
> rc = pnd2_probe();
> if (rc < 0) {
> - pnd2_printk(KERN_ERR, "Failed to register device with error %d.\n", rc);
> + pnd2_printk(KERN_INFO,
> + "Failed to register device with error %d.\n", rc);
So there's no need to use the word "error"
in the output message either.
"Failed to register device - %d\n", rc
would be enough.
prev parent reply other threads:[~2020-03-20 1:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 6:28 [v1,1/1] EDAC: (pnd2) Fix the log level for message "Failed to register device with error %d" Amy.Shih
2020-03-20 1:54 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e67eefc91d4f54a5fbf64be9e6bee94680461b60.camel@perches.com \
--to=joe@perches.com \
--cc=Amy.Shih@advantech.com.tw \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=oakley.ding@advantech.com.tw \
--cc=rrichter@marvell.com \
--cc=she90122@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).