linux-edac.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Baron <jbaron@akamai.com>
To: Paul Marks <paul@pmarks.net>, linux-edac@vger.kernel.org
Cc: bp@alien8.de, m.chehab@samsung.com
Subject: Re: ie31200_edac missing PCI ID for i3-4370
Date: Thu, 4 Feb 2021 17:59:18 -0500	[thread overview]
Message-ID: <ecb895bf-f384-e5e6-d434-d3a8e06eaf47@akamai.com> (raw)
In-Reply-To: <CAHq9+ShGiB_H6-E=L398zYR=ja16r2OuvJZfU4KLof=segyJbw@mail.gmail.com>



On 1/31/21 7:07 PM, Paul Marks wrote:
> I have an ASRock C226M WS with an i3-4370 CPU.
> 
> # lspci -vnn
> 00:00.0 Host bridge [0600]: Intel Corporation 4th Gen Core Processor
>             DRAM Controller [8086:0c00] (rev 06)
>         Subsystem: ASRock Incorporation 4th Gen Core Processor
>             DRAM Controller [1849:0c00]
>         Flags: bus master, fast devsel, latency 0
>         Capabilities: [e0] Vendor Specific Information: Len=0c <?>
>         Kernel driver in use: hsw_uncore
> 
> But edac-util doesn't work:
> 
> # edac-util -v
> edac-util: Fatal: Unable to get EDAC data: Unable to find EDAC data in sysfs
> 
> I tried this ham-fisted patch:
> 
> # diff -u ./drivers/edac/ie31200_edac.c{.old,}
> --- ./drivers/edac/ie31200_edac.c.old
> +++ ./drivers/edac/ie31200_edac.c
> @@ -58,7 +58,7 @@
>  #define PCI_DEVICE_ID_INTEL_IE31200_HB_3 0x0150
>  #define PCI_DEVICE_ID_INTEL_IE31200_HB_4 0x0158
>  #define PCI_DEVICE_ID_INTEL_IE31200_HB_5 0x015c
> -#define PCI_DEVICE_ID_INTEL_IE31200_HB_6 0x0c04
> +#define PCI_DEVICE_ID_INTEL_IE31200_HB_6 0x0c00
>  #define PCI_DEVICE_ID_INTEL_IE31200_HB_7 0x0c08
>  #define PCI_DEVICE_ID_INTEL_IE31200_HB_8 0x1918
>  #define PCI_DEVICE_ID_INTEL_IE31200_HB_9 0x5918

just curious why you removed here and didn't just add?

> 
> And it seems happy now:
> 
> # lspci -vnn
> 00:00.0 Host bridge [0600]: Intel Corporation 4th Gen Core Processor
>             DRAM Controller [8086:0c00] (rev 06)
>         Subsystem: ASRock Incorporation 4th Gen Core Processor
>             DRAM Controller [1849:0c00]
>         Flags: bus master, fast devsel, latency 0
>         Capabilities: [e0] Vendor Specific Information: Len=0c <?>
>         Kernel driver in use: hsw_uncore
>         Kernel modules: ie31200_edac
> 
> # edac-util -v
> mc0: 0 Uncorrected Errors with no DIMM info
> mc0: 0 Corrected Errors with no DIMM info
> mc0: csrow0: 0 Uncorrected Errors
> mc0: csrow0: mc#0csrow#0channel#0: 0 Corrected Errors
> mc0: csrow1: 0 Uncorrected Errors
> mc0: csrow1: mc#0csrow#1channel#0: 0 Corrected Errors
> edac-util: No errors to report.
> 
> I don't know if it's truly working because I can't overclock the RAM
> to induce ECC errors, but still I think adding 8086:0c00 to this
> driver could be useful.
> 

Cool yeah - I think it makes sense to add if can confirm
that the Intel datasheet says that this cpu uses the same
registers to read errors from as the others. I can certainly
confirm that the other pci ids do increment ce counts...

Thanks,

-Jason

  reply	other threads:[~2021-02-05  0:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-01  0:07 ie31200_edac missing PCI ID for i3-4370 Paul Marks
2021-02-04 22:59 ` Jason Baron [this message]
2021-02-04 23:22   ` Paul Marks
2021-02-09 22:25     ` Jason Baron
2021-02-09 23:58       ` Paul Marks
2021-02-10  3:27         ` Jason Baron
2021-02-10 15:31           ` Jason Baron
     [not found] <CAC0EBY-QL5LP+POpyjjt-8rc7d5r2YC+2gzf-SShrJ6DQoyWqw@mail.gmail.com>
     [not found] ` <CAC0EBY8piMhd=wTKb94_cEP9FHWax_79V+MTt4_cY7jZYdoRkg@mail.gmail.com>
2021-05-15 11:10   ` Rick Moritz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ecb895bf-f384-e5e6-d434-d3a8e06eaf47@akamai.com \
    --to=jbaron@akamai.com \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    --cc=paul@pmarks.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).