From: Dave Hansen <dave.hansen@intel.com>
To: "Meyer, Kyle" <kyle.meyer@hpe.com>,
"Sivanich, Dimitri" <dimitri.sivanich@hpe.com>,
"Wahl, Steve" <steve.wahl@hpe.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"Luck, Tony" <tony.luck@intel.com>,
"Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>,
"yazen.ghannam@amd.com" <yazen.ghannam@amd.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
Subject: Re: [PATCH] RAS/CEC: Move non-debug attributes out of debugfs
Date: Thu, 23 Mar 2023 15:01:21 -0700 [thread overview]
Message-ID: <f3a47826-881f-6542-5db2-63ebf1705cb6@intel.com> (raw)
In-Reply-To: <MW5PR84MB171359C71BF003E287E2323C9B879@MW5PR84MB1713.NAMPRD84.PROD.OUTLOOK.COM>
On 3/23/23 14:52, Meyer, Kyle wrote:
>> Also, why *should* these be part of the stable sysfs ABI? What app is
>> using them? Why does it need them?
> We have system scripts that adjust decay_interval and action_threshold.
> They can't access those attributes when lockdown is enabled. If there is a
> more appropriate place for those attributes, please let me know.
Thanks for the info. That helps a bit. But, I'd also appreciate if you
could expand on this a little more. What "system scripts" are these?
Who is using them? What are they trying to accomplish?
We can try to find the best home for these attributes with that info in
hand, if it's not sysfs.
>> Why these two and only these two? What's left in debugfs?
> The other attributes (pfn and array) are used to test CEC. They are only
> created when RAS_CEC_DEBUG is enabled.
Oh, that's good info too. Can you please include that in some form in
your new changelog?
next prev parent reply other threads:[~2023-03-23 22:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 20:22 [PATCH] RAS/CEC: Move non-debug attributes out of debugfs kyle-meyer
2023-03-23 20:29 ` Dave Hansen
2023-03-23 21:52 ` Meyer, Kyle
2023-03-23 22:01 ` Dave Hansen [this message]
2023-03-24 0:49 ` Borislav Petkov
2023-03-24 20:50 ` Yazen Ghannam
2023-03-27 22:07 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3a47826-881f-6542-5db2-63ebf1705cb6@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dimitri.sivanich@hpe.com \
--cc=hpa@zytor.com \
--cc=kyle.meyer@hpe.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=qiuxu.zhuo@intel.com \
--cc=steve.wahl@hpe.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).