From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3224AC0650F for ; Mon, 5 Aug 2019 07:47:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0B0F3218BE for ; Mon, 5 Aug 2019 07:47:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=zytor.com header.i=@zytor.com header.b="rmpBMccs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726423AbfHEHrs (ORCPT ); Mon, 5 Aug 2019 03:47:48 -0400 Received: from terminus.zytor.com ([198.137.202.136]:44745 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726394AbfHEHrs (ORCPT ); Mon, 5 Aug 2019 03:47:48 -0400 Received: from terminus.zytor.com (localhost [127.0.0.1]) by terminus.zytor.com (8.15.2/8.15.2) with ESMTPS id x757l1eF1629313 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 5 Aug 2019 00:47:01 -0700 DKIM-Filter: OpenDKIM Filter v2.11.0 terminus.zytor.com x757l1eF1629313 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zytor.com; s=2019071901; t=1564991221; bh=XE9h3RcCYOMwSuLRzzlKCzMgMSixjMCVWUaG8IYiZWA=; h=Date:From:Cc:Reply-To:In-Reply-To:References:To:Subject:From; b=rmpBMccs6rFtd4/gz0DfZtJRAeJXsq1smw8aAt9xsz6euBCHVcMOGk5QQgKLe8rVH RQcHROlS8CL6vNfjDuUO4FzxJvhZGFrsnSKBboX7TMiEWKvubzUyo67lL9LHFhXFNW VOTEDgRO/tneFNuHMCy682SI3IvqU53QqjjiwM6LoWZU8GXeXZYbXf6/vVDTwe/MzZ 9QPBHLoAt15FXzOdcp3HQGg76OiSG9mAwDkFGO1vT1O5TRVmLo03xtXr943x5Dzls5 ftNyQS6OBFX6P8AV1rMmrp93mN+B950l7+ka5gRnTz1/+LV8bOpZyFV/SWeuVVWwWx +aSSzYl31Cplw== Received: (from tipbot@localhost) by terminus.zytor.com (8.15.2/8.15.2/Submit) id x757kxqr1629307; Mon, 5 Aug 2019 00:46:59 -0700 Date: Mon, 5 Aug 2019 00:46:59 -0700 X-Authentication-Warning: terminus.zytor.com: tipbot set sender to tipbot@zytor.com using -f From: tip-bot for Tony Luck Message-ID: Cc: linux-edac@vger.kernel.org, x86@kernel.org, mingo@redhat.com, tony.luck@intel.com, tglx@linutronix.de, bp@suse.de, linux-kernel@vger.kernel.org, yongkaiwu@tencent.com, mingo@kernel.org, hpa@zytor.com Reply-To: mingo@redhat.com, tony.luck@intel.com, tglx@linutronix.de, linux-edac@vger.kernel.org, x86@kernel.org, hpa@zytor.com, bp@suse.de, linux-kernel@vger.kernel.org, yongkaiwu@tencent.com, mingo@kernel.org In-Reply-To: <20190718182920.32621-1-tony.luck@intel.com> References: <20190718182920.32621-1-tony.luck@intel.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:ras/core] x86/mce: Don't check for the overflow bit on action optional machine checks Git-Commit-ID: aaefca8e30d9df7a4ca13c9c8e135dd227b8ff19 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org Commit-ID: aaefca8e30d9df7a4ca13c9c8e135dd227b8ff19 Gitweb: https://git.kernel.org/tip/aaefca8e30d9df7a4ca13c9c8e135dd227b8ff19 Author: Tony Luck AuthorDate: Thu, 18 Jul 2019 11:29:20 -0700 Committer: Borislav Petkov CommitDate: Mon, 5 Aug 2019 09:34:02 +0200 x86/mce: Don't check for the overflow bit on action optional machine checks We currently do not process SRAO (Software Recoverable Action Optional) machine checks if they are logged with the overflow bit set to 1 in the machine check bank status register. This is overly conservative. There are two cases where we could end up with an SRAO+OVER log based on the SDM volume 3 overwrite rules in "Table 15-8. Overwrite Rules for UC, CE, and UCR Errors" 1) First a corrected error is logged, then the SRAO error overwrites. The second error overwrites the first because uncorrected errors have a higher severity than corrected errors. 2) The SRAO error was logged first, followed by a correcetd error. In this case the first error is retained in the bank. So in either case the machine check bank will contain the address of the SRAO error. So we can process that even if the overflow bit was set. Reported-by: Yongkai Wu Signed-off-by: Tony Luck Signed-off-by: Borislav Petkov Cc: "H. Peter Anvin" Cc: Ingo Molnar Cc: linux-edac Cc: Thomas Gleixner Cc: x86-ml Link: https://lkml.kernel.org/r/20190718182920.32621-1-tony.luck@intel.com --- arch/x86/kernel/cpu/mce/severity.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/cpu/mce/severity.c b/arch/x86/kernel/cpu/mce/severity.c index 210f1f5db5f7..87bcdc6dc2f0 100644 --- a/arch/x86/kernel/cpu/mce/severity.c +++ b/arch/x86/kernel/cpu/mce/severity.c @@ -107,11 +107,11 @@ static struct severity { */ MCESEV( AO, "Action optional: memory scrubbing error", - SER, MASK(MCI_STATUS_OVER|MCI_UC_AR|MCACOD_SCRUBMSK, MCI_STATUS_UC|MCACOD_SCRUB) + SER, MASK(MCI_UC_AR|MCACOD_SCRUBMSK, MCI_STATUS_UC|MCACOD_SCRUB) ), MCESEV( AO, "Action optional: last level cache writeback error", - SER, MASK(MCI_STATUS_OVER|MCI_UC_AR|MCACOD, MCI_STATUS_UC|MCACOD_L3WB) + SER, MASK(MCI_UC_AR|MCACOD, MCI_STATUS_UC|MCACOD_L3WB) ), /* ignore OVER for UCNA */