From mboxrd@z Thu Jan 1 00:00:00 1970 From: Henrique de Moraes Holschuh Subject: Re: [PATCH v2 1/3] firmware loader: Introduce new API - request_firmware_abort() Date: Mon, 3 Nov 2014 08:15:58 -0200 Message-ID: <20141103101558.GA11739@khazad-dum.debian.net> References: <1414984030-13859-1-git-send-email-hock.leong.kweh@intel.com> <1414984030-13859-2-git-send-email-hock.leong.kweh@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1414984030-13859-2-git-send-email-hock.leong.kweh-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kweh Hock Leong Cc: Matt Fleming , Ming Lei , Sam Protsenko , Greg Kroah-Hartman , LKML , linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ong Boon Leong List-Id: linux-efi@vger.kernel.org On Mon, 03 Nov 2014, Kweh Hock Leong wrote: > Note for people who use request_firmware_nowait(): > You are required to do your own synchronization after you call > request_firmware_abort() in order to continue unloading the > module. The example synchronization code shows below: > > while (THIS_MODULE && module_refcount(THIS_MODULE)) > msleep(20); This is _so_ asking for people to get it wrong, it is not funny :-( -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh