linux-efi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
To: Scott Ashcroft <scott.ashcroft-qw6QB7/foO7QT0dZR+AlfA@public.gmane.org>
Cc: Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"H . Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
	Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
	Ard Biesheuvel
	<ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Maarten Lankhorst
	<maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Matthew Garrett <mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>,
	Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>,
	Ben Hutchings <ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>,
	Raphael Hertzog <hertzog-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>,
	Roger Shimizu
	<rogershimizu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Alexis Murzeau <amurzeau-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] x86/efi: Always map boot service regions into new EFI page tables
Date: Sun, 13 Mar 2016 21:58:47 +0000	[thread overview]
Message-ID: <20160313215847.GA2619@codeblueprint.co.uk> (raw)
In-Reply-To: <1457888975.3884.9.camel-qw6QB7/foO7QT0dZR+AlfA@public.gmane.org>

(Fixing Maarten's email address which I botched originally)

On Sun, 13 Mar, at 05:09:35PM, Scott Ashcroft wrote:
> On Fri, 2016-03-11 at 11:19 +0000, Matt Fleming wrote:
> > Some machines have EFI regions in page zero (physical address
> > 0x00000000) and historically that region has been added to the e820
> > map via trim_bios_range(), and ultimately mapped into the kernel page
> > tables. It was not mapped via efi_map_regions() as one would expect.
> > 
> > Alexis reports that with the new separate EFI page tables some boot
> > services regions, such as page zero, are not mapped. This triggers an
> > oops during the SetVirtualAddressMap() runtime call.
> 
> 
> I'm still seeing a failure to boot even with this patch.
> 
> http://www.qzxyz.com/IMG_20160313_164601.jpgSorry for the dodgy photo but the screen has almost a mirror finish.
> 
> Attached is the dmesg from 4.4 with efi=debug memblock=debug

Well, crap. Can you enable CONFIG_EFI_PGT_DUMP and send the dmesg
because it would be good to know how things are mapped before this
patch.

I'd be surprised if the issue you're seeing is related to the one that
Alexis reported. Having corrupt page table structures is a whole new
bag of scary.

Does $(grep pdpe1gb /proc/cpuinfo) show any output on your machine?

  parent reply	other threads:[~2016-03-13 21:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-11 11:19 [GIT PULL] EFI urgent fix for v4.6 queue Matt Fleming
     [not found] ` <1457695163-29632-1-git-send-email-matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-03-11 11:19   ` [PATCH] x86/efi: Always map boot service regions into new EFI page tables Matt Fleming
2016-03-13 17:09     ` Scott Ashcroft
     [not found]       ` <1457888975.3884.9.camel-qw6QB7/foO7QT0dZR+AlfA@public.gmane.org>
2016-03-13 21:58         ` Matt Fleming [this message]
     [not found]           ` <20160313215847.GA2619-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-03-13 23:07             ` Matt Fleming
2016-03-13 23:44               ` Scott Ashcroft
     [not found]               ` <20160313230736.GB2619-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-03-14  1:09                 ` Scott Ashcroft
2016-03-14 10:30                 ` Ingo Molnar
     [not found]                   ` <20160314103019.GA32573-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-03-14 11:35                     ` Matt Fleming
     [not found]                       ` <20160314113502.GC2619-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-03-14 12:05                         ` Ingo Molnar
     [not found]                           ` <20160314120502.GA17388-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-03-14 14:27                             ` Matt Fleming
     [not found]                               ` <20160314142734.GE2619-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-03-14 16:47                                 ` Ingo Molnar
2016-03-15 15:54                                   ` Matt Fleming
     [not found]                                     ` <20160315155418.GH2619-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-03-15 16:05                                       ` Borislav Petkov
2016-03-15 16:25                                       ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160313215847.GA2619@codeblueprint.co.uk \
    --to=matt-mf/unelci9gs6ibeejttw/xrex20p6io@public.gmane.org \
    --cc=amurzeau-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org \
    --cc=bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org \
    --cc=hertzog-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org \
    --cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org \
    --cc=rogershimizu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=scott.ashcroft-qw6QB7/foO7QT0dZR+AlfA@public.gmane.org \
    --cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).