From: Wang YanQing <udknight-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Matt Fleming
<matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
"H . Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
Ard Biesheuvel
<ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
David Herrmann
<dh.herrmann-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Peter Jones <pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Tomi Valkeinen <tomi.valkeinen-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH 2/3] x86/sysfb_efi: Fix valid BAR address range check
Date: Wed, 4 May 2016 23:43:47 +0800 [thread overview]
Message-ID: <20160504154344.GA3146@udknight> (raw)
In-Reply-To: <20160504063524.GB12846-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Wed, May 04, 2016 at 08:35:24AM +0200, Ingo Molnar wrote:
>
> * Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> wrote:
>
> > From: Wang YanQing <udknight-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >
> > We can't just break out when meet start is equal to zero,
>
> Hm, wot?
>
> Thanks,
>
> Ingo
Sorry for my poor English ,and poor commit message, this bring
trouble for more than one maintainer, I guess.
The old code use below comparion as condition to terminate valid
range check without care whether there are more ranges in later
BARs:
"
if (start == 0)
break;
"
I guess original author think (or make a mistake) when we meet a
address range begin from zero means it is a invalid address range,
and no valid address ranges in remain BARs.
So I said:
We can't break the loop when meet range whose start address is zero,
without check it and remaining BARs' range.
Thanks.
next prev parent reply other threads:[~2016-05-04 15:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 19:29 [GIT PULL 0/3] EFI urgent fixes Matt Fleming
[not found] ` <1462303781-8686-1-git-send-email-matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-05-03 19:29 ` [PATCH 1/3] MAINTAINERS: Remove asterisk from EFI directory names Matt Fleming
2016-05-03 19:29 ` [PATCH 2/3] x86/sysfb_efi: Fix valid BAR address range check Matt Fleming
2016-05-04 6:35 ` Ingo Molnar
2016-05-04 9:25 ` Matt Fleming
2016-05-04 10:23 ` Ingo Molnar
[not found] ` <20160504102340.GA4470-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-05-04 10:29 ` Matt Fleming
[not found] ` <20160504063524.GB12846-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-05-04 15:43 ` Wang YanQing [this message]
2016-05-03 19:29 ` [PATCH 3/3] x86/efi-bgrt: Switch all pr_err() to pr_notice() for invalid BGRT Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160504154344.GA3146@udknight \
--to=udknight-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=dh.herrmann-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org \
--cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=tomi.valkeinen-l0cyMroinI0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).