From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3D64C4646B for ; Thu, 20 Jun 2019 14:00:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C4EE320B1F for ; Thu, 20 Jun 2019 14:00:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726866AbfFTOAc (ORCPT ); Thu, 20 Jun 2019 10:00:32 -0400 Received: from mx2.suse.de ([195.135.220.15]:48630 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726802AbfFTOAb (ORCPT ); Thu, 20 Jun 2019 10:00:31 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 8BBB1AEF8; Thu, 20 Jun 2019 14:00:28 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 1187D1E434F; Thu, 20 Jun 2019 16:00:28 +0200 (CEST) Date: Thu, 20 Jun 2019 16:00:28 +0200 From: Jan Kara To: "Darrick J. Wong" Cc: matthew.garrett@nebula.com, yuchao0@huawei.com, tytso@mit.edu, ard.biesheuvel@linaro.org, josef@toxicpanda.com, clm@fb.com, adilger.kernel@dilger.ca, viro@zeniv.linux.org.uk, jack@suse.com, dsterba@suse.com, jaegeuk@kernel.org, jk@ozlabs.org, reiserfs-devel@vger.kernel.org, linux-efi@vger.kernel.org, devel@lists.orangefs.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-nilfs@vger.kernel.org, linux-mtd@lists.infradead.org, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH 2/6] vfs: flush and wait for io when setting the immutable flag via SETFLAGS Message-ID: <20190620140028.GH30243@quack2.suse.cz> References: <156022836912.3227213.13598042497272336695.stgit@magnolia> <156022838496.3227213.3771632042609589318.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <156022838496.3227213.3771632042609589318.stgit@magnolia> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Mon 10-06-19 21:46:25, Darrick J. Wong wrote: > From: Darrick J. Wong > > When we're using FS_IOC_SETFLAGS to set the immutable flag on a file, we > need to ensure that userspace can't continue to write the file after the > file becomes immutable. To make that happen, we have to flush all the > dirty pagecache pages to disk to ensure that we can fail a page fault on > a mmap'd region, wait for pending directio to complete, and hope the > caller locked out any new writes by holding the inode lock. > > Signed-off-by: Darrick J. Wong ... > diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c > index 6aa1df1918f7..a05341b94d98 100644 > --- a/fs/ext4/ioctl.c > +++ b/fs/ext4/ioctl.c > @@ -290,6 +290,9 @@ static int ext4_ioctl_setflags(struct inode *inode, > jflag = flags & EXT4_JOURNAL_DATA_FL; > > err = vfs_ioc_setflags_check(inode, oldflags, flags); > + if (err) > + goto flags_out; > + err = vfs_ioc_setflags_flush_data(inode, flags); > if (err) > goto flags_out; > ... > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 8dad3c80b611..9c899c63957e 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -3548,7 +3548,41 @@ static inline struct sock *io_uring_get_socket(struct file *file) > > int vfs_ioc_setflags_check(struct inode *inode, int oldflags, int flags); > > +/* > + * Do we need to flush the file data before changing attributes? When we're > + * setting the immutable flag we must stop all directio writes and flush the > + * dirty pages so that we can fail the page fault on the next write attempt. > + */ > +static inline bool vfs_ioc_setflags_need_flush(struct inode *inode, int flags) > +{ > + if (S_ISREG(inode->i_mode) && !IS_IMMUTABLE(inode) && > + (flags & FS_IMMUTABLE_FL)) > + return true; > + > + return false; > +} > + > +/* > + * Flush file data before changing attributes. Caller must hold any locks > + * required to prevent further writes to this file until we're done setting > + * flags. > + */ > +static inline int inode_flush_data(struct inode *inode) > +{ > + inode_dio_wait(inode); > + return filemap_write_and_wait(inode->i_mapping); > +} > + > +/* Flush file data before changing attributes, if necessary. */ > +static inline int vfs_ioc_setflags_flush_data(struct inode *inode, int flags) > +{ > + if (vfs_ioc_setflags_need_flush(inode, flags)) > + return inode_flush_data(inode); > + return 0; > +} > + But this is racy at least for page faults, isn't it? What protects you against write faults just after filemap_write_and_wait() has finished? So either you need to set FS_IMMUTABLE_FL before flushing data or you need to get more protection from the fs than just i_rwsem. In the case of ext4 that would be i_mmap_rwsem but other filesystems don't have equivalent protection... Honza -- Jan Kara SUSE Labs, CR