From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D966CC43613 for ; Thu, 20 Jun 2019 21:37:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B59872084A for ; Thu, 20 Jun 2019 21:37:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726067AbfFTVhx (ORCPT ); Thu, 20 Jun 2019 17:37:53 -0400 Received: from mga18.intel.com ([134.134.136.126]:34601 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725815AbfFTVhx (ORCPT ); Thu, 20 Jun 2019 17:37:53 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2019 14:37:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,398,1557212400"; d="scan'208";a="162491010" Received: from mudigirx-mobl1.gar.corp.intel.com (HELO localhost) ([10.252.61.12]) by fmsmga007.fm.intel.com with ESMTP; 20 Jun 2019 14:37:48 -0700 Date: Fri, 21 Jun 2019 00:37:46 +0300 From: Jarkko Sakkinen To: Matthew Garrett Cc: Ard Biesheuvel , Hariprasad Kelam , tpmdd-devel@lists.sourceforge.net, linux-efi , Linux Kernel Mailing List Subject: Re: [PATCH] drivers: firmware: efi: fix gcc warning -Wint-conversion Message-ID: <20190620213722.GA17841@linux.intel.com> References: <20190615040210.GA9112@hari-Inspiron-1545> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Wed, Jun 19, 2019 at 03:48:23PM -0700, Matthew Garrett wrote: > On Wed, Jun 19, 2019 at 2:55 AM Ard Biesheuvel > wrote: > > > > (+ Jarkko, tpmdd, Matthew) > > > > On Sat, 15 Jun 2019 at 06:02, Hariprasad Kelam > > wrote: > > > > > > This patch fixes below warning > > > > > > drivers/firmware/efi/tpm.c:78:38: warning: passing argument 1 of > > > ‘tpm2_calc_event_log_size’ makes pointer from integer without a cast > > > [-Wint-conversion] > > > > > > Signed-off-by: Hariprasad Kelam > > > > I think we already have a fix queued for this, no? > > It looks like I fixed this in "Don't duplicate events from the final > event log in the TCG2 log" rather than a separate patch - I'm fine > merging this, based on Jarkko's preferences. Right! OK, I squashed just the fix to the earlier patch. Master and next are updated. Can you take a peek of [1] and see if it looks legit given all the fuzz around these changes? Then I'm confident enough to do the 5.3 PR. [1] git://git.infradead.org/users/jjs/linux-tpmdd.git /Jarkko