From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: linux-efi@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
linux-kernel@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Jonathan Richardson <jonathan.richardson@broadcom.com>,
Luo XinanX <xinanx.luo@intel.com>,
"Prakhya, Sai Praneeth" <sai.praneeth.prakhya@intel.com>,
Qian Cai <cai@lca.pw>, Tian Baofeng <baofeng.tian@intel.com>
Subject: [PATCH 3/4] x86/efi: fix a -Wtype-limits compilation warning
Date: Sat, 22 Jun 2019 10:51:05 +0200 [thread overview]
Message-ID: <20190622085106.24859-4-ard.biesheuvel@linaro.org> (raw)
In-Reply-To: <20190622085106.24859-1-ard.biesheuvel@linaro.org>
From: Qian Cai <cai@lca.pw>
Compiling a kernel with W=1 generates this warning,
arch/x86/platform/efi/quirks.c:731:16: warning: comparison of unsigned
expression >= 0 is always true [-Wtype-limits]
Fixes: 3425d934fc03 ("efi/x86: Handle page faults occurring while running ...")
Signed-off-by: Qian Cai <cai@lca.pw>
Acked-by: "Prakhya, Sai Praneeth" <sai.praneeth.prakhya@intel.com>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
arch/x86/platform/efi/quirks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/platform/efi/quirks.c b/arch/x86/platform/efi/quirks.c
index 632b83885867..3b9fd679cea9 100644
--- a/arch/x86/platform/efi/quirks.c
+++ b/arch/x86/platform/efi/quirks.c
@@ -728,7 +728,7 @@ void efi_recover_from_page_fault(unsigned long phys_addr)
* Address range 0x0000 - 0x0fff is always mapped in the efi_pgd, so
* page faulting on these addresses isn't expected.
*/
- if (phys_addr >= 0x0000 && phys_addr <= 0x0fff)
+ if (phys_addr <= 0x0fff)
return;
/*
--
2.20.1
next prev parent reply other threads:[~2019-06-22 8:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-22 8:51 [GIT PULL 0/4] EFI fixes for v5.2 Ard Biesheuvel
2019-06-22 8:51 ` [PATCH 1/4] efi/memreserve: deal with memreserve entries in unmapped memory Ard Biesheuvel
2019-06-22 8:51 ` [PATCH 2/4] efi/bgrt: Drop BGRT status field reserved bits check Ard Biesheuvel
2019-06-22 8:51 ` Ard Biesheuvel [this message]
2019-06-22 8:51 ` [PATCH 4/4] efibc: Replace variable set function in notifier call Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190622085106.24859-4-ard.biesheuvel@linaro.org \
--to=ard.biesheuvel@linaro.org \
--cc=baofeng.tian@intel.com \
--cc=cai@lca.pw \
--cc=hdegoede@redhat.com \
--cc=jonathan.richardson@broadcom.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=sai.praneeth.prakhya@intel.com \
--cc=tglx@linutronix.de \
--cc=xinanx.luo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).