From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
matthew.garrett@nebula.com, yuchao0@huawei.com, tytso@mit.edu,
shaggy@kernel.org, ard.biesheuvel@linaro.org,
josef@toxicpanda.com, hch@infradead.org, clm@fb.com,
adilger.kernel@dilger.ca, jk@ozlabs.org, jack@suse.com,
dsterba@suse.com, jaegeuk@kernel.org, cluster-devel@redhat.com,
jfs-discussion@lists.sourceforge.net, linux-efi@vger.kernel.org,
Jan Kara <jack@suse.cz>,
reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, linux-nilfs@vger.kernel.org,
linux-mtd@lists.infradead.org, ocfs2-devel@oss.oracle.com,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/5] vfs: create a generic checking function for FS_IOC_FSSETXATTR
Date: Wed, 26 Jun 2019 08:43:02 -0700 [thread overview]
Message-ID: <20190626154302.GA31445@infradead.org> (raw)
In-Reply-To: <20190626153542.GE5171@magnolia>
On Wed, Jun 26, 2019 at 08:35:42AM -0700, Darrick J. Wong wrote:
> > static inline void simple_fill_fsxattr(struct fsxattr *fa, unsigned xflags)
> > {
> > memset(fa, 0, sizeof(*fa));
> > fa->fsx_xflags = xflags;
> > }
> >
> > and let the compiler optimize the crap out?
>
> The v2 series used to do that, but Christoph complained that having a
> helper for a two-line memset and initialization was silly[1] so now we
> have this version.
>
> I don't mind reinstating it as a static inline helper, but I'd like some
> input from any of the btrfs developers (or you, Al) about which form is
> preferred.
I complained having that helper in btrfs. I think Al wants a generic
one, which at least makes a little more sense.
That being said I wonder if we should lift these attr ioctls to
file op methods and deal with all that crap in VFS code instead of
having all those duplicated ioctl parsers.
next prev parent reply other threads:[~2019-06-26 15:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 2:32 [PATCH v3 0/5] vfs: clean up SETFLAGS and FSSETXATTR option processing Darrick J. Wong
2019-06-26 2:32 ` [PATCH 1/5] vfs: create a generic checking and prep function for FS_IOC_SETFLAGS Darrick J. Wong
2019-06-26 4:02 ` Al Viro
2019-06-26 15:30 ` Darrick J. Wong
2019-06-26 12:20 ` [Cluster-devel] " Bob Peterson
2019-06-26 2:32 ` [PATCH 2/5] vfs: create a generic checking function for FS_IOC_FSSETXATTR Darrick J. Wong
2019-06-26 4:11 ` Al Viro
2019-06-26 15:35 ` Darrick J. Wong
2019-06-26 15:43 ` Christoph Hellwig [this message]
2019-06-27 0:19 ` Darrick J. Wong
2019-06-26 2:32 ` [PATCH 3/5] vfs: teach vfs_ioc_fssetxattr_check to check project id info Darrick J. Wong
2019-06-26 2:32 ` [PATCH 4/5] vfs: teach vfs_ioc_fssetxattr_check to check extent size hints Darrick J. Wong
2019-06-26 2:32 ` [PATCH 5/5] vfs: only allow FSSETXATTR to set DAX flag on files and dirs Darrick J. Wong
2019-06-28 18:33 [PATCH v4 0/5] vfs: clean up SETFLAGS and FSSETXATTR option processing Darrick J. Wong
2019-06-28 18:34 ` [PATCH 2/5] vfs: create a generic checking function for FS_IOC_FSSETXATTR Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626154302.GA31445@infradead.org \
--to=hch@infradead.org \
--cc=adilger.kernel@dilger.ca \
--cc=ard.biesheuvel@linaro.org \
--cc=clm@fb.com \
--cc=cluster-devel@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=dsterba@suse.com \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=jk@ozlabs.org \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=reiserfs-devel@vger.kernel.org \
--cc=shaggy@kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).