From: Greg KH <gregkh@linuxfoundation.org>
To: Rolf Eike Beer <eb@emlix.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Matt Fleming <matt@codeblueprint.co.uk>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-efi@vger.kernel.org,
Linux Kernel Developers List <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org, Matthias Kaehlcke <mka@google.com>,
clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: Building arm64 EFI stub with -fpie breaks build of 4.9.x (undefined reference to `__efistub__GLOBAL_OFFSET_TABLE_')
Date: Fri, 2 Aug 2019 09:57:45 +0200 [thread overview]
Message-ID: <20190802075745.GI26174@kroah.com> (raw)
In-Reply-To: <2102708.6BiaULqomI@devpool35>
On Thu, Jun 06, 2019 at 09:11:00AM +0200, Rolf Eike Beer wrote:
> Nick Desaulniers wrote:
> > On Wed, Jun 5, 2019 at 10:27 AM Nick Desaulniers
> >
> > <ndesaulniers@google.com> wrote:
> > > On Wed, Jun 5, 2019 at 9:26 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> > > > On Wed, Jun 05, 2019 at 05:19:40PM +0200, Rolf Eike Beer wrote:
> > > > > I decided to dig out a toy project which uses a DragonBoard 410c. This
> > > > > has
> > > > > been "running" with kernel 4.9, which I would keep this way for
> > > > > unrelated
> > > > > reasons. The vanilla 4.9 kernel wasn't bootable back then, but it was
> > > > > buildable, which was good enough.
> > > > >
> > > > > Upgrading the kernel to 4.9.180 caused the boot to suddenly fail:
> > > > >
> > > > > aarch64-unknown-linux-gnueabi-ld:
> > > > > ./drivers/firmware/efi/libstub/lib.a(arm64- stub.stub.o): in function
> > > > > `handle_kernel_image':
> > > > > /tmp/e2/build/linux-4.9.139/drivers/firmware/efi/libstub/arm64-stub.c:
> > > > > 63:
> > > > > undefined reference to `__efistub__GLOBAL_OFFSET_TABLE_'
> > > > > aarch64-unknown-linux-gnueabi-ld:
> > > > > ./drivers/firmware/efi/libstub/lib.a(arm64- stub.stub.o): relocation
> > > > > R_AARCH64_ADR_PREL_PG_HI21 against symbol
> > > > > `__efistub__GLOBAL_OFFSET_TABLE_' which may bind externally can not
> > > > > be used when making a shared object; recompile with -fPIC
> > > > > /tmp/e2/build/linux-4.9.139/drivers/firmware/efi/libstub/arm64-stub.c:
> > > > > 63:
> > > > > (.init.text+0xc): dangerous relocation: unsupported relocation
> > > > > /tmp/e2/build/linux-4.9.139/Makefile:1001: recipe for target 'vmlinux'
> > > > > failed -make[1]: *** [vmlinux] Error 1
> > > > >
> > > > > This is caused by commit 27b5ebf61818749b3568354c64a8ec2d9cd5ecca from
> > > > > linux-4.9.y (which is 91ee5b21ee026c49e4e7483de69b55b8b47042be),
> > > > > reverting
> > > > > this commit fixes the build.
> > > > >
> > > > > This happens with vanilla binutils 2.32 and gcc 8.3.0 as well as
> > > > > 9.1.0. See
> > > > > the attached .config for reference.
> > > > >
> > > > > If you have questions or patches just ping me.
> > > >
> > > > Does Linus's latest tree also fail for you (or 5.1)?
> > > >
> > > > Nick, do we need to add another fix that is in mainline for this to work
> > > > properly?
> > > >
> > > > thanks,
> > > >
> > > > greg k-h
> > >
> > > Doesn't immediately ring any bells for me.
> >
> > Upstream commits:
> > dd6846d77469 ("arm64: drop linker script hack to hide __efistub_ symbols")
> > 1212f7a16af4 ("scripts/kallsyms: filter arm64's __efistub_ symbols")
> >
> > Look related to __efistub__ prefixes on symbols and aren't in stable
> > 4.9 (maybe Rolf can try cherry picks of those).
>
> I now have cherry-picked these commits:
>
> dd6846d77469
> fdfb69a72522e97f9105a6d39a5be0a465951ed8
> 1212f7a16af4
> 56067812d5b0e737ac2063e94a50f76b810d6ca3
>
> The 2 additional ones were needed as dependencies of the others. Nothing of
> this has helped.
Did this ever get resolved, or is it still an issue?
thanks,
greg k-h
next prev parent reply other threads:[~2019-08-02 7:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <779905244.a0lJJiZRjM@devpool35>
2019-06-05 16:26 ` Building arm64 EFI stub with -fpie breaks build of 4.9.x (undefined reference to `__efistub__GLOBAL_OFFSET_TABLE_') Greg KH
2019-06-05 17:27 ` Nick Desaulniers
2019-06-05 17:50 ` Nick Desaulniers
2019-06-06 7:11 ` Rolf Eike Beer
2019-08-02 7:57 ` Greg KH [this message]
2019-08-02 8:09 ` Nathan Chancellor
2019-08-02 8:16 ` Rolf Eike Beer
2019-06-05 18:42 ` Ard Biesheuvel
2019-06-05 19:26 ` Greg KH
2019-06-05 20:48 ` Nick Desaulniers
2019-06-06 6:55 ` Ard Biesheuvel
2019-06-06 7:08 ` Greg KH
2019-06-06 8:58 ` Ard Biesheuvel
2019-06-06 9:34 ` Ard Biesheuvel
2019-06-06 7:38 ` Rolf Eike Beer
2019-06-06 7:50 ` Rolf Eike Beer
2019-06-06 9:01 ` Ard Biesheuvel
2019-06-06 9:40 ` Rolf Eike Beer
2019-06-06 9:54 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190802075745.GI26174@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=clang-built-linux@googlegroups.com \
--cc=eb@emlix.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mka@google.com \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).