From: <Narendra.K@dell.com>
To: <geert@linux-m68k.org>
Cc: <ard.biesheuvel@linaro.org>, <linux-efi@vger.kernel.org>,
<Mario.Limonciello@dell.com>, <tglx@linutronix.de>,
<linux-kernel@vger.kernel.org>, <james.morse@arm.com>,
<mingo@kernel.org>
Subject: Re: [PATCH] Ask user input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y
Date: Fri, 11 Oct 2019 09:43:42 +0000 [thread overview]
Message-ID: <20191011094322.GA3065@localhost.localdomain> (raw)
In-Reply-To: <CAMuHMdVriPMVWdNOD4ytZQFPmad7CvD_4utbw1PxMJBua1TSfQ@mail.gmail.com>
Hi Geert,
On Thu, Oct 10, 2019 at 08:50:45PM +0200, Geert Uytterhoeven wrote:
[...]
> > > > drivers/firmware/efi/Kconfig | 5 ++++-
> > > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
> > > > index 178ee8106828..6e4c46e8a954 100644
> > > > --- a/drivers/firmware/efi/Kconfig
> > > > +++ b/drivers/firmware/efi/Kconfig
> > > > @@ -181,7 +181,10 @@ config RESET_ATTACK_MITIGATION
> > > > reboots.
> > > >
> > > > config EFI_RCI2_TABLE
> > > > - bool "EFI Runtime Configuration Interface Table Version 2 Support"
> > > > + bool
> > > > + prompt "EFI RCI Table Version 2 Support" if X86 || COMPILE_TEST
>
> Why the split of bool and prompt?
> Why not simply add a single line "depends on X86 || COMPILE_TEST"?
It is because of the findings shared in [1]. Please let me know your
thoughts on the findings.
>
> > >
> > > You can drop the || COMPILE_TEST as well.
> >
> > I will drop this part of the change in the next version of the patch.
>
> Why drop that part? Isn't it good to have more compile test coverage?
It is per the suggestion in the previous review comment.
Ard, please share your thought here. I could add the || COMPILE_TEST.
[1] Re: [PATCH 4/5] efi: Export Runtime Configuration Interface table to sysfs
https://lore.kernel.org/linux-efi/20190812150452.27983-1-ard.biesheuvel@linaro.org/T/#mebff9ba48499808f59b33b2daef2d94e006296d8
--
With regards,
Narendra K
next prev parent reply other threads:[~2019-10-11 9:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 19:44 [PATCH] Ask user input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y Narendra.K
2019-10-09 14:11 ` Ard Biesheuvel
2019-10-10 17:47 ` Narendra.K
2019-10-10 18:50 ` Geert Uytterhoeven
2019-10-11 9:43 ` Narendra.K [this message]
2019-10-11 10:01 ` Geert Uytterhoeven
2019-10-11 12:55 ` Narendra.K
2019-10-12 17:04 ` Geert Uytterhoeven
2019-10-13 19:08 ` Narendra.K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011094322.GA3065@localhost.localdomain \
--to=narendra.k@dell.com \
--cc=Mario.Limonciello@dell.com \
--cc=ard.biesheuvel@linaro.org \
--cc=geert@linux-m68k.org \
--cc=james.morse@arm.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).