From: "Paul E. McKenney" <paulmck@kernel.org>
To: Marco Elver <elver@google.com>
Cc: LKMM Maintainers -- Akira Yokosawa <akiyks@gmail.com>,
Alan Stern <stern@rowland.harvard.edu>,
Alexander Potapenko <glider@google.com>,
Andrea Parri <parri.andrea@gmail.com>,
Andrey Konovalov <andreyknvl@google.com>,
Andy Lutomirski <luto@kernel.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Arnd Bergmann <arnd@arndb.de>, Boqun Feng <boqun.feng@gmail.com>,
Borislav Petkov <bp@alien8.de>, Daniel Axtens <dja@axtens.net>,
Daniel Lustig <dlustig@nvidia.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
David Howells <dhowells@redhat.com>,
Dmitry Vyukov <dvyukov@google.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Jade Alglave <j.alglave@ucl.ac.uk>,
Joel Fernandes <joel@joelfernandes.org>,
Jonathan Corbet <corbet@lwn.net>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Luc Maranget <luc.maranget@inria.fr>,
Mark Rutland <mark.rutland@arm.com>,
Nicholas Piggin <npiggin@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Will Deacon <will@kernel.org>,
kasan-dev <kasan-dev@googlegroups.com>,
linux-arch <linux-arch@vger.kernel.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
linux-efi@vger.kernel.org,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
the arch/x86 maintainers <x86@kernel.org>
Subject: Re: [PATCH v3 0/9] Add Kernel Concurrency Sanitizer (KCSAN)
Date: Mon, 4 Nov 2019 11:46:58 -0800 [thread overview]
Message-ID: <20191104194658.GK20975@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <CANpmjNOtR6NEsXGo=M1o26d8vUyF7gwj=gew+LAeE_D+qfbEmQ@mail.gmail.com>
On Mon, Nov 04, 2019 at 07:41:30PM +0100, Marco Elver wrote:
> On Mon, 4 Nov 2019 at 17:47, Paul E. McKenney <paulmck@kernel.org> wrote:
> >
> > On Mon, Nov 04, 2019 at 03:27:36PM +0100, Marco Elver wrote:
> > > This is the patch-series for the Kernel Concurrency Sanitizer (KCSAN).
> > > KCSAN is a sampling watchpoint-based data-race detector. More details
> > > are included in Documentation/dev-tools/kcsan.rst. This patch-series
> > > only enables KCSAN for x86, but we expect adding support for other
> > > architectures is relatively straightforward (we are aware of
> > > experimental ARM64 and POWER support).
> > >
> > > To gather early feedback, we announced KCSAN back in September, and
> > > have integrated the feedback where possible:
> > > http://lkml.kernel.org/r/CANpmjNPJ_bHjfLZCAPV23AXFfiPiyXXqqu72n6TgWzb2Gnu1eA@mail.gmail.com
> > >
> > > We want to point out and acknowledge the work surrounding the LKMM,
> > > including several articles that motivate why data-races are dangerous
> > > [1, 2], justifying a data-race detector such as KCSAN.
> > > [1] https://lwn.net/Articles/793253/
> > > [2] https://lwn.net/Articles/799218/
> > >
> > > The current list of known upstream fixes for data-races found by KCSAN
> > > can be found here:
> > > https://github.com/google/ktsan/wiki/KCSAN#upstream-fixes-of-data-races-found-by-kcsan
> >
> > Making this more accessible to more people seems like a good thing.
> > So, for the series:
> >
> > Acked-by: Paul E. McKenney <paulmck@kernel.org>
>
> Much appreciated. Thanks, Paul!
>
> Any suggestions which tree this could eventually land in?
I would guess that Dmitry might have some suggestions.
Thanx, Paul
> Thanks,
> -- Marco
>
> > > Changelog
> > > ---------
> > > v3:
> > > * Major changes:
> > > - Add microbenchmark.
> > > - Add instruction watchpoint skip randomization.
> > > - Refactor API and core runtime fast-path and slow-path. Compared to
> > > the previous version, with a default config and benchmarked using the
> > > added microbenchmark, this version is 3.8x faster.
> > > - Make __tsan_unaligned __alias of generic accesses.
> > > - Rename kcsan_{begin,end}_atomic ->
> > > kcsan_{nestable,flat}_atomic_{begin,end}
> > > - For filter list in debugfs.c use kmalloc+krealloc instead of
> > > kvmalloc.
> > > - Split Documentation into separate patch.
> > >
> > > v2: http://lkml.kernel.org/r/20191017141305.146193-1-elver@google.com
> > > * Major changes:
> > > - Replace kcsan_check_access(.., {true, false}) with
> > > kcsan_check_{read,write}.
> > > - Change atomic-instrumented.h to use __atomic_check_{read,write}.
> > > - Use common struct kcsan_ctx in task_struct and for per-CPU interrupt
> > > contexts.
> > >
> > > v1: http://lkml.kernel.org/r/20191016083959.186860-1-elver@google.com
> > >
> > > Marco Elver (9):
> > > kcsan: Add Kernel Concurrency Sanitizer infrastructure
> > > kcsan: Add Documentation entry in dev-tools
> > > objtool, kcsan: Add KCSAN runtime functions to whitelist
> > > build, kcsan: Add KCSAN build exceptions
> > > seqlock, kcsan: Add annotations for KCSAN
> > > seqlock: Require WRITE_ONCE surrounding raw_seqcount_barrier
> > > asm-generic, kcsan: Add KCSAN instrumentation for bitops
> > > locking/atomics, kcsan: Add KCSAN instrumentation
> > > x86, kcsan: Enable KCSAN for x86
> > >
> > > Documentation/dev-tools/index.rst | 1 +
> > > Documentation/dev-tools/kcsan.rst | 217 +++++++++
> > > MAINTAINERS | 11 +
> > > Makefile | 3 +-
> > > arch/x86/Kconfig | 1 +
> > > arch/x86/boot/Makefile | 2 +
> > > arch/x86/boot/compressed/Makefile | 2 +
> > > arch/x86/entry/vdso/Makefile | 3 +
> > > arch/x86/include/asm/bitops.h | 6 +-
> > > arch/x86/kernel/Makefile | 7 +
> > > arch/x86/kernel/cpu/Makefile | 3 +
> > > arch/x86/lib/Makefile | 4 +
> > > arch/x86/mm/Makefile | 3 +
> > > arch/x86/purgatory/Makefile | 2 +
> > > arch/x86/realmode/Makefile | 3 +
> > > arch/x86/realmode/rm/Makefile | 3 +
> > > drivers/firmware/efi/libstub/Makefile | 2 +
> > > include/asm-generic/atomic-instrumented.h | 393 +++++++--------
> > > include/asm-generic/bitops-instrumented.h | 18 +
> > > include/linux/compiler-clang.h | 9 +
> > > include/linux/compiler-gcc.h | 7 +
> > > include/linux/compiler.h | 35 +-
> > > include/linux/kcsan-checks.h | 97 ++++
> > > include/linux/kcsan.h | 115 +++++
> > > include/linux/sched.h | 4 +
> > > include/linux/seqlock.h | 51 +-
> > > init/init_task.c | 8 +
> > > init/main.c | 2 +
> > > kernel/Makefile | 6 +
> > > kernel/kcsan/Makefile | 11 +
> > > kernel/kcsan/atomic.h | 27 ++
> > > kernel/kcsan/core.c | 560 ++++++++++++++++++++++
> > > kernel/kcsan/debugfs.c | 275 +++++++++++
> > > kernel/kcsan/encoding.h | 94 ++++
> > > kernel/kcsan/kcsan.h | 131 +++++
> > > kernel/kcsan/report.c | 306 ++++++++++++
> > > kernel/kcsan/test.c | 121 +++++
> > > kernel/sched/Makefile | 6 +
> > > lib/Kconfig.debug | 2 +
> > > lib/Kconfig.kcsan | 119 +++++
> > > lib/Makefile | 3 +
> > > mm/Makefile | 8 +
> > > scripts/Makefile.kcsan | 6 +
> > > scripts/Makefile.lib | 10 +
> > > scripts/atomic/gen-atomic-instrumented.sh | 17 +-
> > > tools/objtool/check.c | 18 +
> > > 46 files changed, 2526 insertions(+), 206 deletions(-)
> > > create mode 100644 Documentation/dev-tools/kcsan.rst
> > > create mode 100644 include/linux/kcsan-checks.h
> > > create mode 100644 include/linux/kcsan.h
> > > create mode 100644 kernel/kcsan/Makefile
> > > create mode 100644 kernel/kcsan/atomic.h
> > > create mode 100644 kernel/kcsan/core.c
> > > create mode 100644 kernel/kcsan/debugfs.c
> > > create mode 100644 kernel/kcsan/encoding.h
> > > create mode 100644 kernel/kcsan/kcsan.h
> > > create mode 100644 kernel/kcsan/report.c
> > > create mode 100644 kernel/kcsan/test.c
> > > create mode 100644 lib/Kconfig.kcsan
> > > create mode 100644 scripts/Makefile.kcsan
> > >
> > > --
> > > 2.24.0.rc1.363.gb1bccd3e3d-goog
> > >
> >
> > --
> > You received this message because you are subscribed to the Google Groups "kasan-dev" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20191104164717.GE20975%40paulmck-ThinkPad-P72.
next prev parent reply other threads:[~2019-11-04 19:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 14:27 [PATCH v3 0/9] Add Kernel Concurrency Sanitizer (KCSAN) Marco Elver
2019-11-04 14:27 ` [PATCH v3 1/9] kcsan: Add Kernel Concurrency Sanitizer infrastructure Marco Elver
2019-11-06 9:38 ` Dmitry Vyukov
2019-11-06 10:03 ` Marco Elver
2019-11-06 19:11 ` Marco Elver
2019-11-06 19:59 ` kbuild test robot
2019-11-06 20:34 ` kbuild test robot
2019-11-07 18:43 ` Marco Elver
2019-11-07 21:08 ` Bhupesh Sharma
2019-11-08 14:23 ` Marco Elver
2019-11-04 14:27 ` [PATCH v3 2/9] kcsan: Add Documentation entry in dev-tools Marco Elver
2019-11-04 14:27 ` [PATCH v3 3/9] objtool, kcsan: Add KCSAN runtime functions to whitelist Marco Elver
2019-11-04 14:27 ` [PATCH v3 4/9] build, kcsan: Add KCSAN build exceptions Marco Elver
2019-11-04 14:27 ` [PATCH v3 5/9] seqlock, kcsan: Add annotations for KCSAN Marco Elver
2019-11-05 11:35 ` kbuild test robot
2019-11-05 15:22 ` Marco Elver
2019-11-04 14:27 ` [PATCH v3 6/9] seqlock: Require WRITE_ONCE surrounding raw_seqcount_barrier Marco Elver
2019-11-04 14:27 ` [PATCH v3 7/9] asm-generic, kcsan: Add KCSAN instrumentation for bitops Marco Elver
2019-11-04 14:27 ` [PATCH v3 8/9] locking/atomics, kcsan: Add KCSAN instrumentation Marco Elver
2019-11-04 14:27 ` [PATCH v3 9/9] x86, kcsan: Enable KCSAN for x86 Marco Elver
2019-11-04 16:47 ` [PATCH v3 0/9] Add Kernel Concurrency Sanitizer (KCSAN) Paul E. McKenney
2019-11-04 18:41 ` Marco Elver
2019-11-04 19:46 ` Paul E. McKenney [this message]
2019-11-05 11:10 ` Marco Elver
2019-11-05 14:20 ` Paul E. McKenney
2019-11-05 15:25 ` Marco Elver
2019-11-14 18:05 ` Marco Elver
2019-11-14 19:48 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104194658.GK20975@paulmck-ThinkPad-P72 \
--to=paulmck@kernel.org \
--cc=akiyks@gmail.com \
--cc=andreyknvl@google.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=boqun.feng@gmail.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=dhowells@redhat.com \
--cc=dja@axtens.net \
--cc=dlustig@nvidia.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=hpa@zytor.com \
--cc=j.alglave@ucl.ac.uk \
--cc=joel@joelfernandes.org \
--cc=jpoimboe@redhat.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luc.maranget@inria.fr \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=npiggin@gmail.com \
--cc=parri.andrea@gmail.com \
--cc=peterz@infradead.org \
--cc=stern@rowland.harvard.edu \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).